What format is the tag? The RFC calls it out as a utf8 string, not an opaque, so it’s acceptable to validate it. Since it can be logged we don’t want to totally not check it and open up a vulnerability for attack.

Frank

From: Malahal Naineni [mailto:malahal@gmail.com]
Sent: Monday, September 23, 2019 9:08 PM
To: Satish Chandra Kilaru <iam.kilaru@gmail.com>
Cc: nfs-ganesha <devel@lists.nfs-ganesha.org>
Subject: [NFS-Ganesha-Devel] Re: dnfs + nfsv4 support

I am not sure about the tag whether it needs to be utf-8 string or not, but these issues seem to poor choices made by dnfs. Is it possible to get it fixed rather than changing ganesha code?

Regards, Malahal.

On Sun, Sep 22, 2019 at 7:05 AM Satish Chandra Kilaru <iam.kilaru@gmail.com> wrote:

Hi All,

I have been experimenting with dnfs with nfs-ganesha. It works fine with NFSv3 but not v4. I noticed 2 issues with v4.

1. SetClientID fails as TAG sent by dnfs is not a valid utf8 string. NFS-ganesha is returning NFS4ERR_INVAL in this case. However, nfs-ganesha is using the converted string just for logging. If we skip this check dnfs can proceed further.

2. If length of file handle is not a multiple 4 then dnfs fails. In case of NFSv3 file handles are explicitly padded to make them multiples of 4. Can we do the same for NFSv4.

--Satish
_______________________________________________
Devel mailing list -- devel@lists.nfs-ganesha.org
To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org