We use the patch in our releases, I think some fsals don’t have a concept of opening an fd, so such fsals may benefit as well. It should be trivial to change fsals that use this. I think vfs and gluster use this other than gpfs. 

On Wed, 1 May 2019 at 5:05 AM, <srikrishanmalik@gmail.com> wrote:
Hello,

For unchecked creates ganesha may increment open_fd_count even when no new fd is created by ganesha.
This can happen for v3 when an fd for a file is already open and the client sends a create(unchecked) for the same file, the fsal closes the old fd and reopens the file, but fsal_helper.c:open_by_name increments open_fd_count without checking(no way to do that) whether a new fd is really created.

We will hit this when two clients are trying to create the same file simultaneously, i.e lookup from both clients will fail and both will issue a create, the file will be opened by the first create, the other create will end up just incrementing open_fd_count.

There is a patch(https://gerrithub.io/c/ffilz/nfs-ganesha/+/391267) which may address this, any plans to take this?

Thanks
Sri
_______________________________________________
Devel mailing list -- devel@lists.nfs-ganesha.org
To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org