Martin Schwenke has uploaded this change for review.

View Change

build: Fix developer warning for LSB module

CMake Warning (dev) at /usr/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:438 (message):
  The package name passed to `find_package_handle_standard_args`
  (LSB_RELEASE) does not match the name of the calling package (LSB).  This
  can lead to problems in calling code that expects `find_package` result
  variables (e.g., `_FOUND`) to follow a certain pattern.
Call Stack (most recent call first):
  cmake/modules/FindLSB.cmake:85 (find_package_handle_standard_args)
  CMakeLists.txt:1632 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

Rename the module to LSBRelease and make that the first argument to
find_package_handle_standard_args().

Other options are:

* Pass LSB as the first argument.  This just seems confusing.

* Rename the module to LSB_RELEASE.  Given that there are no cmake
  modules with names containing underscores, this doesn't seem like
  the right solution.

Signed-off-by: Martin Schwenke <mschwenke@ddn.com>
Change-Id: If0e3c80378db8aa97e8f0b6f69d91ef0f8201e3f
---
M src/CMakeLists.txt
R src/cmake/modules/FindLSBRelease.cmake
2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/554766/1

To view, visit change 554766. To unsubscribe, or for help writing mail filters, visit settings.