On 11/13/18 17:19, Jeff Layton wrote:

Hi Patrice!

I've got a set of patches queued up that add the userspace RCU libraries
as a mandatory build requirement for ganesha. The CEA tests for these
patches are currently failing because those machines lack the package.

Could you change the CEA CI to install that package prior to building
ganesha? On RHEL/CentOS, it's in the EPEL repository and is called
userspace-rcu-devel. I don't know what it's called in debian-land
though.

Here's a corresponding PR for the gluster/centos CI:

     https://github.com/nfs-ganesha/ci-tests/pull/39

CEA needs to do something similar.

Thanks!

Hi Jeff,


I will try to do it on thursday.

Done.

With userspace_rcu_devel installed, your patchs are now raising the following errors at compilation :

[ 58%] Building C object MainNFSD/CMakeFiles/FsalCore.dir/__/FSAL/posix_acls.c.o
/opt/nfs-ganesha/src/MainNFSD/9p_rdma_dispatcher.c:67:2: error: implicit declaration of function 'rcu_register_thread' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        rcu_register_thread();
        ^
[ 59%] Building C object Protocols/NFS/CMakeFiles/nfsproto.dir/nfs4_op_putpubfh.c.o
/opt/nfs-ganesha/src/MainNFSD/9p_rdma_dispatcher.c:97:2: error: implicit declaration of function 'rcu_unregister_thread' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        rcu_unregister_thread();
        ^
/opt/nfs-ganesha/src/MainNFSD/9p_rdma_dispatcher.c:97:2: note: did you mean 'rcu_register_thread'?
/opt/nfs-ganesha/src/MainNFSD/9p_rdma_dispatcher.c:67:2: note: 'rcu_register_thread' declared here
        rcu_register_thread();
        ^
/opt/nfs-ganesha/src/MainNFSD/9p_rdma_dispatcher.c:144:2: error: implicit declaration of function 'rcu_register_thread' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        rcu_register_thread();
        ^
/opt/nfs-ganesha/src/MainNFSD/9p_rdma_dispatcher.c:195:2: error: implicit declaration of function 'rcu_unregister_thread' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        rcu_unregister_thread();
        ^
/opt/nfs-ganesha/src/MainNFSD/9p_rdma_dispatcher.c:335:2: error: implicit declaration of function 'rcu_register_thread' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        rcu_register_thread();
        ^
/opt/nfs-ganesha/src/MainNFSD/9p_rdma_dispatcher.c:426:2: error: implicit declaration of function 'rcu_unregister_thread' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        rcu_unregister_thread();
        ^
6 errors generated.
make[2]: *** [MainNFSD/CMakeFiles/MainServices.dir/build.make:193: MainNFSD/CMakeFiles/MainServices.dir/9p_rdma_dispatcher.c.o] Error 1

It begins with patch : "432324: Have threads register and unregister with RCU".

Regards,

-- 
Patrice LUCAS
Ingenieur-Chercheur, CEA-DAM/DSSI/SISR/LA2S
tel : +33 (0)1 69 26 47 86
e-mail : patrice.lucas@cea.fr