shaharhoch@google.com has uploaded this change for review.

View Change

nfs4_op_create: Squash explicit owner attributes in NFS4_OP_CREATE

Unlike nfs4_op_open() and nfs4_op_setattr(), nfs4_op_create() converts
client-supplied createattrs via nfs4_Fattr_To_FSAL_attr() without
calling squash_setattr(&sattr). A squashed client (Root_Squash,
Root_Id_Squash, or All_Squash) supplying explicit FATTR4_OWNER or
FATTR4_OWNER_GROUP of 0 in CREATE can therefore create root-owned
directories, symlinks, or special files instead of having ownership
squashed to the export's anonymous IDs.

Call squash_setattr(&sattr) after nfs4_Fattr_To_FSAL_attr() in
nfs4_op_create().

Change-Id: I15197838bbaae11ce914bc92a8429a3b6f613171
Signed-off-by: Shahar Hochma <shaharhoch@google.com>
---
M src/Protocols/NFS/nfs4_op_create.c
1 file changed, 5 insertions(+), 0 deletions(-)

git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/1259042/1

To view, visit change 1259042. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I15197838bbaae11ce914bc92a8429a3b6f613171
Gerrit-Change-Number: 1259042
Gerrit-PatchSet: 1
Gerrit-Owner: shaharhoch@google.com