What Ganesha version are you seeing this in? If current, could you submit a gerrithub patch?






From: Krishna Harathi [mailto:krishna.harathi@arcserve.com]
Sent: Wednesday, May 4, 2022 4:14 PM
To: devel@lists.nfs-ganesha.org
Subject: [NFS-Ganesha-Devel] NFS Ganesha in mdcache_avl_qp_lookup_s()




Long time. We are seeing a crash shown below. After seeing the fix in this commit - https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516675,

I am posting a possible fix.  


(gdb) where
#0  0x00000000004f2a34 in avl_dirent_hk_cmpf (lhs=0x2, rhs=0x7f82ebf8b5c8) at ../../../../FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.h:67
#1  0x00000000004f3d48 in avltree_do_lookup (tree=0x7f82d31bbd90, cmp_fn=0x4f2a30 <avl_dirent_hk_cmpf>, is_left=<synthetic pointer>, 
    unbalanced=<synthetic pointer>, pparent=<synthetic pointer>, key=0x7f82ebf8b5c8) at ../../../../include/avltree.h:223
#2  avltree_inline_lookup (cmp_fn=0x4f2a30 <avl_dirent_hk_cmpf>, tree=0x7f82d31bbd90, key=0x7f82ebf8b5c8) at ../../../../include/avltree.h:244
#3  avltree_lookup (tree=0x7f82d31bbd90, key=0x7f82ebf8b5c8) at ../../../../include/avltree.h:252
#4  mdcache_avl_qp_lookup_s (entry=entry@entry=0x7f82d31bb800, name=name@entry=0x7f82c606f440 "meta.tmp", maxj=maxj@entry=1)
    at ../../../../FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c:779



Possible fix –


diff mdcache_avl.c mdcache_avl.c.new 


>     memset(&v, 0, sizeof(v));



I also suggest reviewing all callers of this avltree_lookup() for potential similar problems. Comments?



Krishna Harathi



Krishna Harathi  |  Senior Manager - Engineering
Office: 503.475.5279  |  Mobile: 503.475.5279  |  krishna.harathi@arcserve.com
arcserve.com  |  Twitter  |  LinkedIn  |  YouTube


If you are not the intended recipient of this message or received it erroneously, please notify the sender and delete it, together with any attachments, and be advised that any dissemination or copying of this message is prohibited.