Suhas Athani has uploaded this change for review.

View Change

Fix null pointer dereference in SEQUENCE op

Add null check for session->clientid_record before calling
nfs_rpc_get_chan() to prevent NULL pointer dereference.

- nfs_rpc_get_chan(session->clientid_record, 0) is called without
checking if session->clientid_record is NULL.

- nfs_rpc_get_chan() immediately dereferences the clientid parameter
(accesses clientid->cid_minorversion), causing a NULL pointer
dereference if session->clientid_record is NULL.

- Line 315 later checks for NULL, but this is too late.

Change-Id: I48c7e052acfe7845ae25e96928b81d12b8a9af0b
Signed-off-by: Suhas Athani <Suhas.Athani@ibm.com>
---
M src/Protocols/NFS/nfs4_op_sequence.c
1 file changed, 3 insertions(+), 1 deletion(-)

git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/83/1225683/1

To view, visit change 1225683. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I48c7e052acfe7845ae25e96928b81d12b8a9af0b
Gerrit-Change-Number: 1225683
Gerrit-PatchSet: 1
Gerrit-Owner: Suhas Athani <Suhas.Athani@ibm.com>