Attention is currently required from: Frank Filz.

Lior Suliman would like Frank Filz to review this change.

View Change

fsal_helper: Change order of mode bits check in fsal_setattr

Previously, the first check set ATTR_MODE as valid if ATTR_OWNER or
ATTR_GROUP was valid. Then, the the next check looked at if ATTR_MODE
was valid. But, there could be a case where it is not originally valid
and just because valid due to our code.

Changing the order fixes this issue.

Change-Id: I4586e5014807227f9f1721a81af676216cc6d6ee
Signed-off-by: Lior Suliman <liorsu@gmail.com>
---
M src/FSAL/fsal_helper.c
1 file changed, 19 insertions(+), 18 deletions(-)

git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/1204539/1

To view, visit change 1204539. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I4586e5014807227f9f1721a81af676216cc6d6ee
Gerrit-Change-Number: 1204539
Gerrit-PatchSet: 1
Gerrit-Owner: Lior Suliman <liorsu@google.com>
Gerrit-Reviewer: Frank Filz <ffilzlnx@mindspring.com>
Gerrit-Attention: Frank Filz <ffilzlnx@mindspring.com>