Venky Shankar has uploaded this change for review.

View Change

nfs_core/qos: put the export and client refs taken for Cluster QoS messages

cluster_qos_process_pe() looks up the export named in a received
Cluster QoS message with get_gsh_export() but never drops that
reference, so every PUBLISH, [UN]SUBSCRIBE message a node receives
pins the export once more. Once the export is removed, its refcount
never reaches zero causing the export to be never freed and its FSAL
export is never released. With FSAL_CEPH, the libcephfs mount and
its CephFS session outlive the export causing the MDS to spend
unnecessary time waiting in up:clientreplay state during upgrades.
More details in the GitHub issue on why that happens. Samwe with
per-client QoS.

Drop the references once the message has been handled.

GitHub Issue: #1441
Fixes: 7cf951750 ("Cluster QoS module implementation")
Change-Id: Id626f1a71e97fffc063c80598bc1b5311dba0474
Signed-off-by: Venky Shankar <vshankar@redhat.com>
---
M src/MainNFSD/nfs_cluster_qos.c
1 file changed, 4 insertions(+), 0 deletions(-)

git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/1260078/1

To view, visit change 1260078. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Id626f1a71e97fffc063c80598bc1b5311dba0474
Gerrit-Change-Number: 1260078
Gerrit-PatchSet: 1
Gerrit-Owner: Venky Shankar <vshankar@redhat.com>