Hi folks!

Apologies for the sudden dump of ~40 changes, but I wanted to make sure I understood what I was doing :).

This patch series adds an NFSv3 proxy following the example from the NFSv4 proxy that Ganesha already has. I saw a few people ask for this on the list, and it seemed easy enough to do. I'll happily rebase and go edit whatever is needed, and expect this to be a slightly long review.

One thing I wanted to highlight though, is that I explicitly chose to make this a separate FSAL rather than intermingle it with the V4 proxy. While there's probably some opportunity for sharing, it seemed easier to confine each to their own directory, particularly since a V3 server can't handle V4 clients correctly (you could translate some things to let it "kind of work", but that seems risky).

I've also left the series as I did it over the few weeks rather than squashing the commits. Each one builds and does whatever I tested in the commit message, but I didn't choose to squash these (yet). My hope is that it serves to also show what it took to "learn" the FSAL API and what was really required.

Overall, this was a great experience!






On Tue, Mar 17, 2020 at 3:29 PM Solomon Boulos (GerritHub) <gerrit@gerrithub.io> wrote:

Solomon Boulos has uploaded this change for review.

View Change

Initial NFSv3 proxying FSAL.

This code just builds, is able to get parsed and correctly explode as
soon as the first lookup_path request. Next up, implement some ops.

Change-Id: I45926761389ef61af281f7ba0f7e643fd32b4ee5
Signed-off-by: Solomon Boulos <boulos@google.com>
---
M src/CMakeLists.txt
M src/FSAL/CMakeLists.txt
A src/FSAL/FSAL_PROXY_V3/CMakeLists.txt
A src/FSAL/FSAL_PROXY_V3/main.c
A src/FSAL/FSAL_PROXY_V3/proxyv3_fsal_methods.h
A src/config_samples/proxy_v3.conf
M src/doc/man/ganesha-config.rst
A src/doc/man/ganesha-proxy-v3-config.rst
8 files changed, 325 insertions(+), 0 deletions(-)

git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/487439/1

To view, visit change 487439. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I45926761389ef61af281f7ba0f7e643fd32b4ee5
Gerrit-Change-Number: 487439
Gerrit-PatchSet: 1
Gerrit-Owner: Solomon Boulos <boulos@google.com>
Gerrit-MessageType: newchange
_______________________________________________
Devel mailing list -- devel@lists.nfs-ganesha.org
To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org