10:49 p.m.
Hi,
For client with ReadOnly access and user with ReadWrite access, Ganesha
returns READ/MODIFY/APPEND allowed on ACCESS call.
Linux kernel NFS returns just READ allowed for same.
I think we need to fix Ganesha’s behaviour, we should return access rights
based on client access check also.
Please check the patch attached to fix the behaviour.
Regards,
Gaurav
12:31 p.m.
I think you’re right. Could you submit this patch to Gerrithub (see
src/CONTRIBUTING_HOWTO.txt).
Frank
From: gaurav gangalwar [mailto:gaurav.gangalwar@gmail.com]
Sent: Sunday, October 28, 2018 10:50 PM
To: devel(a)lists.nfs-ganesha.org
Subject: [NFS-Ganesha-Devel] Access check issue for RO client.
Hi,
For client with ReadOnly access and user with ReadWrite access, Ganesha returns
READ/MODIFY/APPEND allowed on ACCESS call.
Linux kernel NFS returns just READ allowed for same.
I think we need to fix Ganesha’s behaviour, we should return access rights based on client
access check also.
Please check the patch attached to fix the behaviour.
Regards,
Gaurav
10:13 p.m.
Sure, I will submit the patch.
Regards,
Gaurav
On Tue, Oct 30, 2018 at 1:01 AM Frank Filz <ffilzlnx(a)mindspring.com> wrote:
I think you’re right. Could you submit this patch to Gerrithub (see
src/CONTRIBUTING_HOWTO.txt).
Frank
*From:* gaurav gangalwar [mailto:gaurav.gangalwar@gmail.com]
*Sent:* Sunday, October 28, 2018 10:50 PM
*To:* devel(a)lists.nfs-ganesha.org
*Subject:* [NFS-Ganesha-Devel] Access check issue for RO client.
Hi,
For client with ReadOnly access and user with ReadWrite access, Ganesha
returns READ/MODIFY/APPEND allowed on ACCESS call.
Linux kernel NFS returns just READ allowed for same.
I think we need to fix Ganesha’s behaviour, we should return access rights
based on client access check also.
Please check the patch attached to fix the behaviour.
Regards,
Gaurav
1:53 a.m.
I submitted the patch,
https://review.gerrithub.io/#/c/ffilz/nfs-ganesha/+/431359/
This is the test case to check,
From RO client if we try to append existing file, applications don't get
any error even though write fails.
[root@centos71 tld]# cat a.txt
Mon Oct 22 11:33:46 EDT 2018
[root@centos71 tld]# echo "hi" >> a.txt
[root@centos71 tld]# cat a.txt
Mon Oct 22 11:33:46 EDT 2018
With the fix above it errors out with proper error.
[root@centos71 tld]# cat a.txt
Mon Oct 22 11:33:46 EDT 2018
[root@centos71 tld]# echo "hi" >> a.txt
bash: a.txt: Permission Denied
Regards,
Gaurav
On Tue, Oct 30, 2018 at 10:43 AM gaurav gangalwar <
gaurav.gangalwar(a)gmail.com> wrote:
Sure, I will submit the patch.
Regards,
Gaurav
On Tue, Oct 30, 2018 at 1:01 AM Frank Filz <ffilzlnx(a)mindspring.com>
wrote:
> I think you’re right. Could you submit this patch to Gerrithub (see
> src/CONTRIBUTING_HOWTO.txt).
>
>
>
> Frank
>
>
>
> *From:* gaurav gangalwar [mailto:gaurav.gangalwar@gmail.com]
> *Sent:* Sunday, October 28, 2018 10:50 PM
> *To:* devel(a)lists.nfs-ganesha.org
> *Subject:* [NFS-Ganesha-Devel] Access check issue for RO client.
>
>
>
> Hi,
>
> For client with ReadOnly access and user with ReadWrite access, Ganesha
> returns READ/MODIFY/APPEND allowed on ACCESS call.
>
> Linux kernel NFS returns just READ allowed for same.
>
> I think we need to fix Ganesha’s behaviour, we should return access
> rights based on client access check also.
>
> Please check the patch attached to fix the behaviour.
>
> Regards,
>
> Gaurav
>
1961
days inactive
2000
days old
3 comments
2 participants
participants (2)
-
Frank Filz -
gaurav gangalwar