From Jeff Layton <jlayton@redhat.com>: Jeff Layton has uploaded this change for review. ( https://review.gerrithub.io/414188 Change subject: SAL: make recovery_init operation an int return ...................................................................... SAL: make recovery_init operation an int return If the recovery_init operation fails, then we're likely to end up crashing later anyway as certain pointers we rely on will end up being NULL, etc. Failure to initialize the recovery backend should really be a fatal startup error that prevents the server from starting. Make recovery_init an int return operation and have the server die if it fails with an error. Change-Id: I3fb8ce57e7715801cc069970c782a26d4a61d894 Signed-off-by: Jeff Layton <jlayton@redhat.com> --- M src/MainNFSD/nfs_lib.c M src/MainNFSD/nfs_main.c M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_fs.c M src/SAL/recovery/recovery_fs_ng.c M src/SAL/recovery/recovery_rados_cluster.c M src/SAL/recovery/recovery_rados_kv.c M src/SAL/recovery/recovery_rados_ng.c M src/include/sal_functions.h 9 files changed, 37 insertions(+), 21 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/414188/1 -- To view, visit https://review.gerrithub.io/414188 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: I3fb8ce57e7715801cc069970c782a26d4a61d894 Gerrit-Change-Number: 414188 Gerrit-PatchSet: 1 Gerrit-Owner: Jeff Layton <jlayton@redhat.com>