Ganesha crashe in dec_nlm_state_ref.
Hello All, Ganesha: V2.5.0.4 Windows client: Windows 10 Pro Testing NFSv3 access from windows client. Sometimes Ganesha crashes in dec_nlm_state_ref. My understanding of the issue is - state is maintained in multiple lists but a single ref is taken for all entries. state mutex is not held while adding/removing it from different lists. this can cause incorrect ref on the state object. Attached patch appears to fix this. However I still need to test more. Any comments on the issue and patch will be highly appreciated. Thanks & Regards, Suhrud
Hi Suhrud, Below patches should fix this issue. https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/424260 https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/423882 On Tue, Nov 27, 2018 at 4:18 PM Suhrud Patankar <suhrudpatankar@gmail.com> wrote:
Hello All,
Ganesha: V2.5.0.4 Windows client: Windows 10 Pro
Testing NFSv3 access from windows client. Sometimes Ganesha crashes in dec_nlm_state_ref.
My understanding of the issue is - state is maintained in multiple lists but a single ref is taken for all entries. state mutex is not held while adding/removing it from different lists. this can cause incorrect ref on the state object.
Attached patch appears to fix this. However I still need to test more. Any comments on the issue and patch will be highly appreciated.
Thanks & Regards, Suhrud _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
-- with regards, Sachin Punadikar
Or just upgrade to 2.7.x Daniel On 11/27/2018 08:45 AM, Sachin Punadikar wrote:
Hi Suhrud, Below patches should fix this issue. https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/424260 https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/423882
On Tue, Nov 27, 2018 at 4:18 PM Suhrud Patankar <suhrudpatankar@gmail.com <mailto:suhrudpatankar@gmail.com>> wrote:
Hello All,
Ganesha: V2.5.0.4 Windows client: Windows 10 Pro
Testing NFSv3 access from windows client. Sometimes Ganesha crashes in dec_nlm_state_ref.
My understanding of the issue is - state is maintained in multiple lists but a single ref is taken for all entries. state mutex is not held while adding/removing it from different lists. this can cause incorrect ref on the state object.
Attached patch appears to fix this. However I still need to test more. Any comments on the issue and patch will be highly appreciated.
Thanks & Regards, Suhrud _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org> To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org <mailto:devel-leave@lists.nfs-ganesha.org>
-- with regards, Sachin Punadikar
_______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
Yes. I found that this is fixed in latest code. Thanks & Regards, Suhrud On Fri, Nov 30, 2018 at 7:48 PM Daniel Gryniewicz <dang@redhat.com> wrote:
Or just upgrade to 2.7.x
Daniel
On 11/27/2018 08:45 AM, Sachin Punadikar wrote:
Hi Suhrud, Below patches should fix this issue. https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/424260 https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/423882
On Tue, Nov 27, 2018 at 4:18 PM Suhrud Patankar <suhrudpatankar@gmail.com <mailto:suhrudpatankar@gmail.com>> wrote:
Hello All,
Ganesha: V2.5.0.4 Windows client: Windows 10 Pro
Testing NFSv3 access from windows client. Sometimes Ganesha crashes in dec_nlm_state_ref.
My understanding of the issue is - state is maintained in multiple lists but a single ref is taken for all entries. state mutex is not held while adding/removing it from different lists. this can cause incorrect ref on the state object.
Attached patch appears to fix this. However I still need to test more. Any comments on the issue and patch will be highly appreciated.
Thanks & Regards, Suhrud _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org> To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org <mailto:devel-leave@lists.nfs-ganesha.org>
-- with regards, Sachin Punadikar
_______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
_______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
participants (3)
-
Daniel Gryniewicz -
Sachin Punadikar -
Suhrud Patankar