Attention is currently required from: Madhu Thorat. Hello Madhu Thorat, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201747?usp=email to review the following change. Change subject: Subject: MDCACHE: Add config param Close_Fast ...................................................................... Subject: MDCACHE: Add config param Close_Fast Add new configuration parameter Close_Fast, so that: - If Close_Fast=false (default) FDs don't get closed immediately after using them. - If Close_Fast=true, then FDs get closed immediately after opening FDs and using them for read/write/commit. This is an updated version of commit f9fb72551ad021a6e3d59d38df1eb618d6ae0bbb from the https://github.com/ganltc/nfs-ganesha.git repository. Much of the original patch applies with manual conflict resolution. However, fsal_start_global_io() has changed completely so a different and much more straightforward change is made to implement the desired behaviour. I chose to use a goto there so the call to wait_to_start_io() retains its prominence as the most important thing happening in this function, rather than demoting it into the body of an if-statement. Seems to work... and seems like it would be cheaper than reducing LRU_Run_Interval to near 0. Signed-off-by: Madhu Thorat <madhu.punjabi@in.ibm.com> Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Change-Id: I61114b9284938e9af77483159c5ddb7281e95c86 --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_ext.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_main.c M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c M src/FSAL/commonlib.c M src/FSAL/fsal_helper.c M src/Protocols/NFS/nfs3_create.c M src/config_samples/config.txt M src/doc/man/ganesha-cache-config.rst M src/include/fsal.h M src/include/mdcache.h 10 files changed, 46 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/47/1201747/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1201747?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I61114b9284938e9af77483159c5ddb7281e95c86 Gerrit-Change-Number: 1201747 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin@meltin.net> Gerrit-Reviewer: Madhu Thorat <madhu.punjabi@in.ibm.com> Gerrit-Attention: Madhu Thorat <madhu.punjabi@in.ibm.com>