Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487204 ) Change subject: If nfs_start_grace get called with refs taken, like after nfs_get_grace_status and before nfs_put_grace_status. Then we will have grace_status with GRACE_STATUS_CHANGE_REQ until next nfs_start_grace, till then some of RPCs will send JUKEBOX. I don't see reaper taking any action if GRACE_STATUS_CHANGE_REQ is set. ...................................................................... If nfs_start_grace get called with refs taken, like after nfs_get_grace_status and before nfs_put_grace_status. Then we will have grace_status with GRACE_STATUS_CHANGE_REQ until next nfs_start_grace, till then some of RPCs will send JUKEBOX. I don't see reaper taking any action if GRACE_STATUS_CHANGE_REQ is set. We should fail the nfs_start_grace, if there are still refs and we were not in grace. Let the caller retry it. Reset the GRACE_STATUS_CHANGE_REQ else it will be set till next nfs_start_grace. Change-Id: I19bba7a1150fd7ac1e61e2a597263ea78fc6b730 Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar@gmail.com> --- M src/MainNFSD/nfs_admin_thread.c M src/SAL/nfs4_recovery.c M src/include/sal_functions.h 3 files changed, 20 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/487204/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/487204 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I19bba7a1150fd7ac1e61e2a597263ea78fc6b730 Gerrit-Change-Number: 487204 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar@gmail.com> Gerrit-MessageType: newchange