I'd like to wrap up Ganesha V4.1, possibly this week. Everyone please look over the Ganesha patches here: https://review.gerrithub.io/q/status:open+project:%255E.*nfs-ganesha.*+branc h:next+repo:ffilz/nfs-ganesha And let me know if there are any that don't have a +2 that you believe really should go into V4.1 and then we will work on getting those patches reviewed and ready for merge. If that can happen this week, that would be great, otherwise, let's shoot for next week. Then after that, I can fork V4-stable and start merging some of the feature stuff into V5-dev. Thanks Frank Filz
Hi Frank, On Mon, 12 Sep 2022 08:54:57 -0700, "Frank Filz" <ffilzlnx@mindspring.com> wrote:
I'd like to wrap up Ganesha V4.1, possibly this week. Everyone please look over the Ganesha patches here:
https://review.gerrithub.io/q/status:open+project:%255E.*nfs-ganesha.*+branc h:next+repo:ffilz/nfs-ganesha
And let me know if there are any that don't have a +2 that you believe really should go into V4.1 and then we will work on getting those patches reviewed and ready for merge. If that can happen this week, that would be great, otherwise, let's shoot for next week.
As discussed on #ganesha, I'm wondering if the FSAL_VFS ACL patches might be able to sneak into 4.1. We could tweak the last commit to switch it off by default. It doesn't really touch any important code paths. There are some CMakfile changes. It seems an unlikely cause for regressions (famous last words). Frank wanted me to ask what others think... So what do others think? :-) Thanks... peace & happiness, martin
If it's off by default, it's fine with me. Daniel On 9/15/22 05:41, Martin Schwenke wrote:
Hi Frank,
On Mon, 12 Sep 2022 08:54:57 -0700, "Frank Filz" <ffilzlnx@mindspring.com> wrote:
I'd like to wrap up Ganesha V4.1, possibly this week. Everyone please look over the Ganesha patches here:
https://review.gerrithub.io/q/status:open+project:%255E.*nfs-ganesha.*+branc h:next+repo:ffilz/nfs-ganesha
And let me know if there are any that don't have a +2 that you believe really should go into V4.1 and then we will work on getting those patches reviewed and ready for merge. If that can happen this week, that would be great, otherwise, let's shoot for next week.
As discussed on #ganesha, I'm wondering if the FSAL_VFS ACL patches might be able to sneak into 4.1. We could tweak the last commit to switch it off by default. It doesn't really touch any important code paths. There are some CMakfile changes. It seems an unlikely cause for regressions (famous last words).
Frank wanted me to ask what others think... So what do others think? :-)
Thanks...
peace & happiness, martin _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
OK, let’s do that then and get it in. Frank
-----Original Message----- From: Daniel Gryniewicz [mailto:dang@redhat.com] Sent: Thursday, September 15, 2022 7:39 AM To: devel@lists.nfs-ganesha.org Subject: [NFS-Ganesha-Devel] Re: Let's wrap up Ganesha V4.1
If it's off by default, it's fine with me.
Daniel
On 9/15/22 05:41, Martin Schwenke wrote:
Hi Frank,
On Mon, 12 Sep 2022 08:54:57 -0700, "Frank Filz" <ffilzlnx@mindspring.com> wrote:
I'd like to wrap up Ganesha V4.1, possibly this week. Everyone please look over the Ganesha patches here:
https://review.gerrithub.io/q/status:open+project:%255E.*nfs-ganesha. *+branc h:next+repo:ffilz/nfs-ganesha
And let me know if there are any that don't have a +2 that you believe really should go into V4.1 and then we will work on getting those patches reviewed and ready for merge. If that can happen this week, that would be great, otherwise, let's shoot for next week.
As discussed on #ganesha, I'm wondering if the FSAL_VFS ACL patches might be able to sneak into 4.1. We could tweak the last commit to switch it off by default. It doesn't really touch any important code paths. There are some CMakfile changes. It seems an unlikely cause for regressions (famous last words).
Frank wanted me to ask what others think... So what do others think? :-)
Thanks...
peace & happiness, martin _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
Thanks, sounds good! New version pushed: * Rebased against next * This hunk moved to a separate commit, for probable merge in v5.0: diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt index 85ed1f336..c2ba15561 100644 --- a/src/CMakeLists.txt +++ b/src/CMakeLists.txt @@ -308,7 +308,7 @@ option(USE_CB_SIMULATOR "enable callback simulator thread" OFF) goption(USE_NFSIDMAP "Use of libnfsidmap for name resolution" ON) option(ENABLE_ERROR_INJECTION "enable error injection" OFF) -goption(ENABLE_VFS_POSIX_ACL "Enable NFSv4 to POSIX ACL mapping for VFS" OFF) +goption(ENABLE_VFS_POSIX_ACL "Enable NFSv4 to POSIX ACL mapping for VFS" ON) option(ENABLE_VFS_DEBUG_ACL "Enable debug ACL store for VFS" OFF) option(ENABLE_RFC_ACL "Use all RFC ACL checks" OFF) option(USE_TOOL_MULTILOCK "build multilock tool" OFF) peace & happiness, martin On Thu, 15 Sep 2022 08:43:46 -0700, "Frank Filz" <ffilzlnx@mindspring.com> wrote:
OK, let’s do that then and get it in.
Frank
-----Original Message----- From: Daniel Gryniewicz [mailto:dang@redhat.com] Sent: Thursday, September 15, 2022 7:39 AM To: devel@lists.nfs-ganesha.org Subject: [NFS-Ganesha-Devel] Re: Let's wrap up Ganesha V4.1
If it's off by default, it's fine with me.
Daniel
On 9/15/22 05:41, Martin Schwenke wrote:
Hi Frank,
On Mon, 12 Sep 2022 08:54:57 -0700, "Frank Filz" <ffilzlnx@mindspring.com> wrote:
I'd like to wrap up Ganesha V4.1, possibly this week. Everyone please look over the Ganesha patches here:
https://review.gerrithub.io/q/status:open+project:%255E.*nfs-ganesha. *+branc h:next+repo:ffilz/nfs-ganesha
And let me know if there are any that don't have a +2 that you believe really should go into V4.1 and then we will work on getting those patches reviewed and ready for merge. If that can happen this week, that would be great, otherwise, let's shoot for next week.
As discussed on #ganesha, I'm wondering if the FSAL_VFS ACL patches might be able to sneak into 4.1. We could tweak the last commit to switch it off by default. It doesn't really touch any important code paths. There are some CMakfile changes. It seems an unlikely cause for regressions (famous last words).
Frank wanted me to ask what others think... So what do others think? :-)
Thanks...
peace & happiness, martin _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
participants (3)
-
Daniel Gryniewicz -
Frank Filz -
Martin Schwenke