Re: Commit duplicating include line and failing make process
I'm not sure about all of that, maybe someone else has an idea. Frank From: Yoann.VALERI@cea.fr [mailto:Yoann.VALERI@cea.fr] Sent: Wednesday, December 8, 2021 7:23 AM To: ffilzlnx@mindspring.com Cc: Philippe.DENIEL@CEA.FR Subject: Commit duplicating include line and failing make process Hello, I am Yoann Valeri, working at CEA with Philippe Deniel on NFS-Ganesha and LibKVSNS. I have been working on NFS-Ganesha for a few months without problem, but recently, after a rebase on next, the "make" process became broken because the function "bswap_16" is not defined in multiple files (the platform I'm using is a CentOS Linux release 8.2.2004 (Core)): * nfs-ganesha/src/FSAL/FSAL_GPFS/fsal_ds.c * nfs-ganesha/src/FSAL/FSAL_GPFS/export.c * nfs-ganesha/src/FSAL/FSAL_MEM/mem_export.c * nfs-ganesha/src/FSAL/FSAL_PSEUDO/export.c After some digging, I found out the source of the problem for the last two files: in commit " 18e0dcf784ebb92fd5b04d9e31955e18cd11bad0", the two includes of "byteswap.h" were changed for "misc/portable.h", and this function is not found anymore. Moreover, in commit "5a72ceda2688297bbc82de436eaebf7d6ab0bf32", this same include "misc/portable.h" was added to remove an "#ifdef", resulting in this file being included twice, but the function "bswap_16" is unknown. By adding back the "byteswap" include, everything works fine on the other hand. However, the first two files also require this include, but they were not changed recently, at least from what I can see, hence I don't really understand why these two became problematic. The duplicated include call is an error, but do you have any idea why the "byteswap" removal for "misc/portable" breaks the building process, and why the other two files also became problems? Thanks for your help, Best regards, Yoann Valeri.
Hi, I could reproduce this issue by mock building the src.rpm with epel-7 and epel-8 flavour, running mock on F34. It seems like it's kind of correlated tp FSAL_GPFS, I have the feeling that switching it off at the cmake level resolves the issue that I have when running mock build. Has anyone encounter such a compilation issue ? Regards Philippe On 12/8/21 19:14, Frank Filz wrote:
I’m not sure about all of that, maybe someone else has an idea.
Frank
*From:*Yoann.VALERI@cea.fr [mailto:Yoann.VALERI@cea.fr] *Sent:* Wednesday, December 8, 2021 7:23 AM *To:* ffilzlnx@mindspring.com *Cc:* Philippe.DENIEL@CEA.FR *Subject:* Commit duplicating include line and failing make process
Hello,
I am Yoann Valeri, working at CEA with Philippe Deniel on NFS-Ganesha and LibKVSNS.
I have been working on NFS-Ganesha for a few months without problem, but recently, after a rebase on next, the "make" process became broken because the function "bswap_16" is not defined in multiple files (the platform I'm using is a CentOS Linux release 8.2.2004 (Core)):
* nfs-ganesha/src/FSAL/FSAL_GPFS/fsal_ds.c * nfs-ganesha/src/FSAL/FSAL_GPFS/export.c * nfs-ganesha/src/FSAL/FSAL_MEM/mem_export.c * nfs-ganesha/src/FSAL/FSAL_PSEUDO/export.c
After some digging, I found out the source of the problem for the last two files: in commit "
18e0dcf784ebb92fd5b04d9e31955e18cd11bad0", the two includes of "byteswap.h" were changed for "misc/portable.h", and this function is not found anymore.
Moreover, in commit "5a72ceda2688297bbc82de436eaebf7d6ab0bf32", this same include "misc/portable.h" was added to remove an "#ifdef", resulting in this file being included twice, but the function "bswap_16" is unknown.
By adding back the "byteswap" include, everything works fine on the other hand.
However, the first two files also require this include, but they were not changed recently, at least from what I can see, hence I don't really understand why these two became problematic.
The duplicated include call is an error, but do you have any idea why the "byteswap" removal for "misc/portable" breaks the building process, and why the other two files also became problems?
Thanks for your help,
Best regards,
Yoann Valeri.
participants (2)
-
Frank Filz -
Philippe DENIEL