Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197070?usp=email ) Change subject: In nfs4_Check_Stateid don't get obj2 reference if no fsal_obj ...................................................................... In nfs4_Check_Stateid don't get obj2 reference if no fsal_obj In the call to get_state_obj_export_owner_refs, don't ask for obj2 if fsal_obj is NULL. We don't need the obj2 reference, and we may not have an op_context to be able to release the reference. This is indeed the case when FREE_STATEID is called without having done a PUTFH. Note that subsequently, FREE_STATEID DOES make it's own call to get_state_obj_export_owner_refs, but it uses the export returned to set up an op_context thus allowing for the put_ref. Fixes github issue #1151 Change-Id: I71bca94c03c120265d610d43784ca879950f18bc Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com> --- M src/SAL/nfs4_state_id.c 1 file changed, 13 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/1197070/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1197070?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I71bca94c03c120265d610d43784ca879950f18bc Gerrit-Change-Number: 1197070 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx@mindspring.com>