Moritz Tanner has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1239044?usp=email ) Change subject: recovery: extract and test nfs4_recovery_build_tag() ...................................................................... recovery: extract and test nfs4_recovery_build_tag() The tag-assembly logic (IP prefix + formatted opaque client owner) was duplicated between recovery_fs.c and recovery_rados_kv.c. Extract it into a shared nfs4_recovery_build_tag() in nfs4_recovery.c and have both backends call it. No change in behavior. Add src/test/test_recovery_tag.c covering the tag format for several opaque value and address shapes. Change-Id: I047ade3bc74cae6e3ab9443c5eeefa5e73de26d4 Signed-off-by: Moritz Tanner <moritz.tanner(a)linbit.com&gt; --- M src/MainNFSD/libganesha_nfsd.ver M src/SAL/nfs4_recovery.c M src/SAL/recovery/recovery_fs.c M src/SAL/recovery/recovery_rados_kv.c M src/include/sal_functions.h M src/test/CMakeLists.txt A src/test/test_recovery_tag.c 7 files changed, 116 insertions(+), 67 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/44/1239044/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1239044?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I047ade3bc74cae6e3ab9443c5eeefa5e73de26d4 Gerrit-Change-Number: 1239044 Gerrit-PatchSet: 1 Gerrit-Owner: Moritz Tanner <moritz.tanner(a)linbit.com&gt;