Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246697?usp=email ) Change subject: Fix compilation error when build time flag USE_DBUS=OFF is used ...................................................................... Fix compilation error when build time flag USE_DBUS=OFF is used The gRPC stats API -- grpc_reset_stats(), grpc_disable_stats(), grpc_get_auth_stats(), grpc_get_v4_full_stats() and server_grpc_fill_nfsmon_iostats() -- calls reset_server_stats(), reset_fsal_stats(), reset_client_stats(), reset_export_stats(), reset_clnt_allops_stats(), server_nfsmon_export_iostats() and the optnlm/optmnt/optqta tables unconditionally. All of those are declared or defined inside #ifdef USE_DBUS, so a build with USE_DBUS=OFF fails: src/support/export_mgr.c: error: implicit declaration of function 'reset_fsal_stats' src/support/server_stats.c: error: 'optnlm' undeclared ld: undefined reference to 'reset_server_stats' None of the affected declarations or definitions takes a DBus type, so they move outside the guard rather than being restructured, keeping the change small. The genuine DBus reporters -- server_dbus_total_ops(), server_dbus_fast_ops() and global_dbus_total_ops() -- stay guarded, as do the inner _USE_NFS3 / _USE_NLM / _USE_RQUOTA guards on the op-name tables. Change-Id: Ia187d531bd1be596e860ddcbae6176a6f993d50b Signed-off-by: Bjorn Leffler <github@leffler.org> --- M src/include/server_stats_private.h M src/support/client_mgr.c M src/support/export_mgr.c M src/support/server_stats.c 4 files changed, 90 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1246697/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1246697?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia187d531bd1be596e860ddcbae6176a6f993d50b Gerrit-Change-Number: 1246697 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <github@leffler.org>