backport the patches to fix up SIGHUP for v2.7?
I was at devconf this week and a couple of folks working with ganesha in production asked specifically about fixing up SIGHUP to remove defunct exports in addition to just adding them. I mentioned that it'll be fixed in v2.8, but they asked about backporting that to v2.7. Should we? In particular, I think we'd need to pull in: f6896176ef87053c5de3351be80416e949ad4bdb eedcd2cf1b4b1b34c24d762a2fb6bc1b3df33aab c328125b59581d95e5593cae2877bc9f5cfba846 46bb5e561ceb2901daa7ebdd87a944c4eb9d01c6 The only potential problem I can see with doing it is that f6896176ef87053c5de3351be80416e949ad4bdb is potentially a behavioral change (it disallows dbus from removing an export that would leave another disconnected from the pseudoroot). It seems unlikely that anyone would be relying on being able to do that, but it is possible. Thoughts? -- Jeff Layton <jlayton@redhat.com>
On 1/29/19 11:18 AM, Jeff Layton wrote:
I was at devconf this week and a couple of folks working with ganesha in production asked specifically about fixing up SIGHUP to remove defunct exports in addition to just adding them. I mentioned that it'll be fixed in v2.8, but they asked about backporting that to v2.7. Should we?
In particular, I think we'd need to pull in:
f6896176ef87053c5de3351be80416e949ad4bdb eedcd2cf1b4b1b34c24d762a2fb6bc1b3df33aab c328125b59581d95e5593cae2877bc9f5cfba846 46bb5e561ceb2901daa7ebdd87a944c4eb9d01c6
The only potential problem I can see with doing it is that f6896176ef87053c5de3351be80416e949ad4bdb is potentially a behavioral change (it disallows dbus from removing an export that would leave another disconnected from the pseudoroot). It seems unlikely that anyone would be relying on being able to do that, but it is possible.
Thoughts?
I'm generally okay with this. Daniel
I was at devconf this week and a couple of folks working with ganesha in production asked specifically about fixing up SIGHUP to remove defunct exports in addition to just adding them. I mentioned that it'll be fixed in v2.8, but they asked about backporting that to v2.7. Should we?
In particular, I think we'd need to pull in:
f6896176ef87053c5de3351be80416e949ad4bdb eedcd2cf1b4b1b34c24d762a2fb6bc1b3df33aab c328125b59581d95e5593cae2877bc9f5cfba846 46bb5e561ceb2901daa7ebdd87a944c4eb9d01c6
The only potential problem I can see with doing it is that f6896176ef87053c5de3351be80416e949ad4bdb is potentially a behavioral change (it disallows dbus from removing an export that would leave another disconnected from the pseudoroot). It seems unlikely that anyone would be relying on being able to do that, but it is possible.
I'm in favor of this backport. The potential issue with dBus remove export is not something I'm worried about since it would break things anyway. Frank
participants (3)
-
Daniel Gryniewicz -
Frank Filz -
Jeff Layton