Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496236 ) Change subject: Add clarification about removal of cih_remove_checked call in 0693097d6 ...................................................................... Add clarification about removal of cih_remove_checked call in 0693097d6 In commit 0693097d61f33d9c8d2bd49b89d448c4f804dd0d a call to cih_remove_checked was removed. This patch documents in comments why that call is not necessary. The call was not necessary because the loop that is unmapping entries and exports will unmap the export root, and if the export root no longer belongs to any export, it will be unhashed inside the loop. The unhash outside the loop did nothing for export roots that only belonged to one export, but any that belonged to two exports would get incorrectly unhashed if one of those two exports was removed. Change-Id: Ic596b516be0dcf7804b9ac5a1ef0976e282e6fb9 Signed-off-by: Frank S. Filz <ffilzlnx@mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/Protocols/NLM/nlm_util.c 2 files changed, 9 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/36/496236/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/496236 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic596b516be0dcf7804b9ac5a1ef0976e282e6fb9 Gerrit-Change-Number: 496236 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx@mindspring.com> Gerrit-MessageType: newchange