Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556505?usp=email ) Change subject: cid_server_scope being a global variable, we were allocating it, with check cid_server_owner[0] == '\0'. But this check is not protected, so this check will be passed by other thread running in parallel, which could result also result in race between allocation by other thread and later memcpy, while building the reply. Hence making allocation atomic, with mutex ...................................................................... cid_server_scope being a global variable, we were allocating it, with check cid_server_owner[0] == '\0'. But this check is not protected, so this check will be passed by other thread running in parallel, which could result also result in race between allocation by other thread and later memcpy, while building the reply. Hence making allocation atomic, with mutex Change-Id: I3e625194f0f20dfe6cecc50141638d1ab40f901c Signed-off-by: Rojin George <itsmerojin@gmail.com> --- M src/Protocols/NFS/nfs4_op_exchange_id.c 1 file changed, 44 insertions(+), 36 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/556505/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556505?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3e625194f0f20dfe6cecc50141638d1ab40f901c Gerrit-Change-Number: 556505 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin@gmail.com> Gerrit-MessageType: newchange