Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238405?usp=email to review the following change. Change subject: Fix buffer overflow and missing null-termination in name2id ...................................................................... Fix buffer overflow and missing null-termination in name2id When idmapping is disabled, `atless2id` was called directly with `name->addr` (which is not guaranteed to be null-terminated), risking out-of-bounds reads. Fix this by copying `name->addr` to a stack- allocated, null-terminated buffer (`namebuff`) before the call. Change-Id: I944a8cc399da9b269ef11ff4319b63b8bb88f391 Signed-off-by: Lior Suliman <liorsu@gmail.com> --- M src/idmapper/idmapper.c M src/include/nfsv41.h 2 files changed, 8 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/05/1238405/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1238405?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I944a8cc399da9b269ef11ff4319b63b8bb88f391 Gerrit-Change-Number: 1238405 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu@google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx@mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx@mindspring.com>