Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556818?usp=email ) Change subject: FSAL_VFS: Don't attempt to get ACLs from symbolic links ...................................................................... FSAL_VFS: Don't attempt to get ACLs from symbolic links acl_get_fd() returns NULL, failing with EBADF, if given a file descriptor for a symlink opened with O_NOFOLLOW. Add an early return with success. This turns the function into a no-op for symlinks, so should guarantee now resource leakage. The GlusterFS FSAL handles this slightly differently. It attempts to get the ACLs and converts failure to success on certain errors. However, here in the VFS FSAL, the errno for a failure of this type might vary between filesystems - various manpages provide little guidance - so avoiding the lookup is probably sane. Signed-off-by: Martin Schwenke <mschwenke@ddn.com> Change-Id: I69945978f25522b26e312f3577e7a13e50a497f1 --- M src/FSAL/FSAL_VFS/vfs/attrs.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/18/556818/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/556818?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I69945978f25522b26e312f3577e7a13e50a497f1 Gerrit-Change-Number: 556818 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin@meltin.net> Gerrit-MessageType: newchange