[S] Change in ...nfs-ganesha[next]: NLM: keep SM_NOTIFY my_name when internal statd frees nodename (#1438)
Dadang NH has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1259632?usp=email ) Change subject: NLM: keep SM_NOTIFY my_name when internal statd frees nodename (#1438) ...................................................................... NLM: keep SM_NOTIFY my_name when internal statd frees nodename (#1438) With Internal_statd, nsm_notify_thread() fires the PORTMAP lookups for every recovered NLM client entry and then releases nodename, since no external statd was ever connected. The SM_NOTIFY itself is only built after the asynchronous PORTMAP reply, so by then nodename is NULL, my_name stays NULL and every SM_NOTIFY fails XDR encoding: rpc :TIRPC :EVENT :xdr_string_encode:979 ERROR missing string pointer req_call :NLM :EVENT :CLNT_CALL_BACK failed: RPC: Can't encode arguments Clients are never told to reclaim, and their NFSv3 locks are lost after a restart. This is a regression from 560a1d6 ("Fix five AddressSanitizer direct memory leaks"); before that the global nodename was never freed. Take the private copy of nodename when the local_nlm_info is first initialised, while the notify thread still holds it. The copy is owned by the request and released by local_nlm_info_free() as before; the existing check where SM_NOTIFY is built then reuses it. Change-Id: I484c6a045408727907aa74177c7d93c6489dba93 Signed-off-by: Dadang NH <project@dadangnh.com> --- M src/Protocols/NLM/nsm.c 1 file changed, 18 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/32/1259632/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1259632?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I484c6a045408727907aa74177c7d93c6489dba93 Gerrit-Change-Number: 1259632 Gerrit-PatchSet: 1 Gerrit-Owner: Dadang NH <project@dadangnh.com>
participants (1)
-
Dadang NH (GerritHub)