I'm not sure understand correctly, but if I do, then I think I disagree. We need to have valid attributes for all the objects in the readdir, so if we can't get them for one object, the readdir must fail. Daniel On 9/29/20 9:13 AM, Olivier Garaud wrote:
I'm sorry the issue is a little bit more tricky, I'll try to explain it clearly:
When we do a READDIR (mdcache_readdir_chunked) we always refresh the attribute cache, which may fail temporarily for one entry and at that point the fattr4_rdattr_error is not handled correctly. Which may fail the whole READDIR and that's not what should happen in that case.
Olivier
On Tue, Sep 29, 2020 at 2:19 PM Olivier Garaud <olivier.garaud@scality.com <mailto:olivier.garaud@scality.com>> wrote:
Hi,
I think we may have an issue with this since the fattr4_rdattr_error attribute is not transferred to the FSAL. See https://tools.ietf.org/html/rfc7530#page-271
Regards,
Olivier
On Tue, Sep 29, 2020 at 1:30 PM Daniel Gryniewicz <dang@redhat.com <mailto:dang@redhat.com>> wrote:
It doesn't. The readdir() API requires that the callback be called with the requested attributes, so it's up to the FSAL to make sure they're there, by calling the appropriate getattr() call if necessary.
Daniel
On 9/28/20 6:10 PM, Bjorn Leffler via Devel wrote: > How does Ganesha (especially MDCACHE) handle readdir responses when some > or all files have no attributes? Is this supported and supposed to work? > > I'm testing proxy configurations against a NetApp filer. NetApp filers > don't return attributes in the readdir response for .snapshot directories. > > Thanks, > Bjorn > > > _______________________________________________ > Devel mailing list -- devel@lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org> > To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org <mailto:devel-leave@lists.nfs-ganesha.org> > _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org> To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org <mailto:devel-leave@lists.nfs-ganesha.org>