Rajesh Prasad has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1243026?usp=email )
Change subject: Used goption for RDMA compile time flags
......................................................................
Used goption for RDMA compile time flags
USE_NFS_RDMA — Ganesha-level, converted to goption(). This is the single
authoritative knob users pass on the cmake command line.
USE_RPC_RDMA — libntirpc-level, kept as plain option(). Two modes:
Embedded build (Ganesha calls add_subdirectory(libntirpc)):
Ganesha propagates the already-resolved USE_NFS_RDMA value with
"CACHE BOOL … FORCE", overriding libntirpc's option() default
before libntirpc's CMakeLists.txt even runs. libntirpc never
needs goption semantics here; it simply sees ON or OFF.
Standalone build (cmake … /path/to/libntirpc):
The user passes -DUSE_RPC_RDMA=ON. libntirpc's plain option()
picks it up. find_package(RDMA REQUIRED) then hard-fails cmake
if the RDMA libraries are absent — the existing REQUIRED keyword
provides the fatal error without any goption machinery.
Change-Id: Ibca784315df620168fed43f0fbf7409369f8578a
Signed-off-by: Rajesh Prasad <raprasad(a)redhat.com>
---
M src/CMakeLists.txt
1 file changed, 14 insertions(+), 7 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/26/1243026/1
--
To view, visit
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1243026?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ibca784315df620168fed43f0fbf7409369f8578a
Gerrit-Change-Number: 1243026
Gerrit-PatchSet: 1
Gerrit-Owner: Rajesh Prasad <raprasad(a)redhat.com>