I meant to say "no need to put them in a list in a conflict case" On Thu, Jul 2, 2020 at 12:36 AM Malahal Naineni <malahal@gmail.com> wrote:
Since we don't implement callbacks or fairness, we could just drop locks of type STATE_NFSV4_BLOCKING? The current code might be there to implement callback in future though, just trying to understand the code.
Regards, Malahal.
On Thu, Jul 2, 2020 at 12:10 AM Frank Filz <ffilzlnx@mindspring.com> wrote:
Yea, the notify lock callback is not supported, that would take some effort to implement non-blocking locks for NFS v4.1 which is complicated in that I'm not sure if the callback is a guaranteed deal, that the client will send some kind of cancellation if it gives up waiting for a blocked lock, If not, then we need to time out 4.x blocked locks. We also have to make them provisional until the client actually comes back with a new lock request, which means they COULD be handed out to another client in the meantime. This provisional (or courtesy) behavior may be hard to assure in a cluster or even a single node where there are other processes using locking on the same file system (since the courtesy lock would be a normal held lock on the backend - Ganesha can only give a conflicting lock out and cancel the courtesy lock for locks that come through that Ganesha instance).
Frank
-----Original Message----- From: Daniel Gryniewicz [mailto:dang@redhat.com] Sent: Wednesday, July 1, 2020 7:21 AM To: devel@lists.nfs-ganesha.org Subject: [NFS-Ganesha-Devel] Re: Callbacks supported with 4.1
It appears the implemented callbacks are layout recall, device notify, delegation recall, and getattr. You can check the callpoints of nfs_rpc_cb_single() to see which callbacks are sent.
Daniel
On 7/1/20 9:13 AM, Trishali Nayar wrote:
Hi all,
Recently while doing some testing we observed that CB_NOTIFY_LOCK callback does not seem to supported by Ganesha. Is that understanding correct?
Also, any insights on the 4.1 callbacks that we do support, would be good to know. The RFC mentions quite a few of them.
Thanks and regards, Trishali.
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Trishali Nayar IBM Systems ETZ, Pune. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
_______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
_______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org