5:35 p.m.
Huh. That’s probably not the preferred change. What does the sockaddr type
look like on your system? (On mine / previously it’s large enough to
contain any sockaddr including the ipv4 and IPv6 variants).
Maybe there’s a more general “largest sockaddr” that I missed?
On Sun, Oct 25, 2020 at 11:02 Kaleb KEITHLEY (GerritHub) <
gerrit(a)gerrithub.io> wrote:
Kaleb KEITHLEY has uploaded this change for *review*.
View Change <https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/504803>
FSAL_PROXY_V3: fix build warning in rpc.c
seen building with gcc-11 on f34/rawhide, but probably not be gcc-11
specific.
...
In function ‘proxyv3_openfd’,
inlined from ‘proxyv3_getfdentry’ at
/home/kkeithle/src/github/scratch/src/FSAL/FSAL_PROXY_V3/rpc.c:490:11,
inlined from ‘proxyv3_getfd_blocking’ at
/home/kkeithle/src/github/scratch/src/FSAL/FSAL_PROXY_V3/rpc.c:543:4,
inlined from ‘proxyv3_call’ at
/home/kkeithle/src/github/scratch/src/FSAL/FSAL_PROXY_V3/rpc.c:699:13:
/home/kkeithle/src/github/scratch/src/FSAL/FSAL_PROXY_V3/rpc.c:157:9: warning: ‘memcpy’
writing 28 bytes into a region of size 16 overflows the destination
[-Wstringop-overflow=]
157 | memcpy(&hostAndPort, host, socklen);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/kkeithle/src/github/scratch/src/FSAL/FSAL_PROXY_V3/rpc.c: In function
‘proxyv3_call’:
/home/kkeithle/src/github/scratch/src/FSAL/FSAL_PROXY_V3/rpc.c:153:25: note: destination
object ‘hostAndPort’
153 | struct sockaddr hostAndPort;
| ^~~~~~~~~~~
...
Change-Id: I807279bf7b690332e2885b290da1281eb6af50a3
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
---
M src/FSAL/FSAL_PROXY_V3/rpc.c
1 file changed, 7 insertions(+), 6 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/504803/1
To view, visit change 504803
<https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/504803>;. To
unsubscribe, or for help writing mail filters, visit settings
<https://review.gerrithub.io/settings>;.
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I807279bf7b690332e2885b290da1281eb6af50a3
Gerrit-Change-Number: 504803
Gerrit-PatchSet: 1
Gerrit-Owner: Kaleb KEITHLEY <kaleb(a)redhat.com>
Gerrit-MessageType: newchange
_______________________________________________
Devel mailing list -- devel(a)lists.nfs-ganesha.org
To unsubscribe send an email to devel-leave(a)lists.nfs-ganesha.org