Attention is currently required from: Frank Filz. Hello Frank Filz, I'd like you to do a code review. Please visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235931?usp=email to review the following change. Change subject: idmapper: Implement RFC 5661 compliant numeric ID parsing ...................................................................... idmapper: Implement RFC 5661 compliant numeric ID parsing This patch introduces string_to_numeric_uid_gid to strictly enforce RFC 5661, Section 5.9 requirements for numeric owners and groups. The new helper ensures: No leading zeros (except for the value "0"). No non-numeric characters (e.g., '+' or '-'). Proper 32-bit range validation with error logging. The atless2id and pwentname2id functions were updated to use this safer parsing logic. Additionally, name2id now bypasses cache lookups and defaults to numeric parsing when ID mapping is disabled. Change-Id: I5f8cd6f9d56041931e54e335d0b03283d1015aca Signed-off-by: Lior Suliman <liorsu@gmail.com> --- M src/idmapper/idmapper.c 1 file changed, 63 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/31/1235931/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1235931?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5f8cd6f9d56041931e54e335d0b03283d1015aca Gerrit-Change-Number: 1235931 Gerrit-PatchSet: 1 Gerrit-Owner: Lior Suliman <liorsu@google.com> Gerrit-Reviewer: Frank Filz <ffilzlnx@mindspring.com> Gerrit-Attention: Frank Filz <ffilzlnx@mindspring.com>