Arnab Tah has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170970?usp=email ) Change subject: ACL: In nfsv4, avoid converting mask into fsal_acl entry ...................................................................... ACL: In nfsv4, avoid converting mask into fsal_acl entry For nfsv4, we drop the mask ACE from the NFS ACL. The code section for skipping ACL_MASK was removed by the commit 11d0261ff9d15079a9d3f7d8c9ff39342d4dd01b Added it back, as we need it for v4. Also, added extra argument to posix_acl_2_fsal_acl() to distinguish v3 callers from others. With current code we end up with a bogus output in nfsv4 ACL, that represent a POSIX mask ACE. $ nfs4_getfacl file1 D::OWNER@:r A::OWNER@:waxtTcCy D::GROUP@:x A::GROUP@:tcy A::GROUP@:xtcy A::EVERYONE@:xtcy $ With fix. $ nfs4_getfacl file1 D::OWNER@:r A::OWNER@:waxtTcCy D::GROUP@:x A::GROUP@:tcy A::EVERYONE@:xtcy $ For nfsv3 ACL, the mask ACE will still be generated. Change-Id: I6c055aa7f71d88ff795af6d1eda849030fd274c0 Signed-off-by: Arnab Tah <atah@ddn.com> --- M src/FSAL/FSAL_CEPH/internal.c M src/FSAL/FSAL_GLUSTER/gluster_internal.c M src/FSAL/FSAL_VFS/vfs/attrs.c M src/FSAL/posix_acls.c M src/Protocols/NFS/nfs_proto_tools.c M src/include/posix_acls.h 6 files changed, 18 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/70/1170970/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1170970?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6c055aa7f71d88ff795af6d1eda849030fd274c0 Gerrit-Change-Number: 1170970 Gerrit-PatchSet: 1 Gerrit-Owner: Arnab Tah <atah@ddn.com> Gerrit-MessageType: newchange