Malahal has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488542 ) Change subject: Make sure no_cleanup is set under the state_lock ...................................................................... Make sure no_cleanup is set under the state_lock We do set no_cleanup to true under the lock, we set it to false after dropping the lock at times! If two threads work on the same object, thread A could acquire the state lock and set this no_cleanup to true, while another thread could set it to false leading to thread A's call stack trying to call state_wipe_file. This would result into lock failure! Always modify no_cleanup under write mode state_lock to avoid this issue. Change-Id: I2313c3849289db4b3d190edb4958a670a4f9ac8f Signed-off-by: Malahal Naineni <malahal@us.ibm.com> --- M src/Protocols/NFS/nfs4_op_open.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/42/488542/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/488542 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2313c3849289db4b3d190edb4958a670a4f9ac8f Gerrit-Change-Number: 488542 Gerrit-PatchSet: 1 Gerrit-Owner: Malahal <malahal@gmail.com> Gerrit-MessageType: newchange