From Kinglong Mee <kinglongmee@gmail.com>: Kinglong Mee has uploaded this change for review. ( https://review.gerrithub.io/423878 Change subject: Fix bad assign logical caused use after freed ...................................................................... Fix bad assign logical caused use after freed A case of entry->attrs contains an old acl, but the new attrs request_mask without ATTR_ACL. Mdcache assign the acl from entry->attrs to attrs at mdc_update_attr_cache, but following fsal_copy_attrs assign it back, after that, both entry->attrs and attrs have the same acl, only one refrence. After that, the acl will be freed when release attrs, the entry->attrs->acl will be used after freed. This patch make sure the entry->attrs->acl is clean. Change-Id: Ibdda58703e9a4a0fecd5af17ba41a003ff26616c Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> --- M src/include/fsal.h 1 file changed, 10 insertions(+), 15 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/423878/1 -- To view, visit https://review.gerrithub.io/423878 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: Ibdda58703e9a4a0fecd5af17ba41a003ff26616c Gerrit-Change-Number: 423878 Gerrit-PatchSet: 1 Gerrit-Owner: Kinglong Mee <kinglongmee@gmail.com>