[NFS-Ganesha-Devel] Re: Change in ...nfs-ganesha[next]: MDCACHE - Add MDCACHE {} config block

Hi Daniel, With the change below, I see parameters in CACHEINODE block are not really assigned to mdcache_param global. Does that mean we should replace it with MDCACHE in existing configs? Even if I don't have MDCACHE block, the mdcache_param will get reset to default values after the second load_config_from_parse() call. Breakpoint 1, mdcache_set_param_from_conf (parse_tree=0x7fffffffe3c0, err_type=0x7ffff7de0891 <config_error_is_harmless+24>) at /home/nutanix/nfs-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c:123 123 { (gdb) print mdcache_param $1 = {nparts = 0, cache_size = 0, getattr_dir_invalidation = false, dir = {avl_chunk = 0, avl_chunk_split = 0, avl_detached_mult = 0, avl_detached_max = 0}, entries_hwmark = 0, entries_release_size = 0, chunks_hwmark = 0, lru_run_interval = 0, fd_limit_percent = 0, fd_hwmark_percent = 0, fd_lwmark_percent = 0, reaper_work = 0, reaper_work_per_lane = 0, biggest_window = 0, required_progress = 0, futility_count = 0, dirmap_hwmark = 0} (gdb) n 124 (void) load_config_from_parse(parse_tree, (gdb) 129 if (!config_error_is_harmless(err_type)) { (gdb) print mdcache_param $2 = {nparts = 7, cache_size = 32633, getattr_dir_invalidation = false, dir = {avl_chunk = 128, avl_chunk_split = 0, avl_detached_mult = 1, avl_detached_max = 0}, entries_hwmark = 100, entries_release_size = 100, chunks_hwmark = 100000, lru_run_interval = 90, fd_limit_percent = 99, fd_hwmark_percent = 90, fd_lwmark_percent = 50, reaper_work = 0, reaper_work_per_lane = 50, biggest_window = 40, required_progress = 5, futility_count = 8, dirmap_hwmark = 10000} (gdb) n 135 (void) load_config_from_parse(parse_tree, (gdb) 140 if (!config_error_is_harmless(err_type)) { (gdb) print mdcache_param $3 = {nparts = 7, cache_size = 32633, getattr_dir_invalidation = false, dir = {avl_chunk = 128, avl_chunk_split = 0, avl_detached_mult = 1, avl_detached_max = 0}, entries_hwmark = 100000, entries_release_size = 100, chunks_hwmark = 100000, lru_run_interval = 90, fd_limit_percent = 99, fd_hwmark_percent = 90, fd_lwmark_percent = 50, reaper_work = 0, reaper_work_per_lane = 50, biggest_window = 40, required_progress = 5, futility_count = 8, dirmap_hwmark = 10000} On Fri, May 17, 2019 at 10:51 AM Daniel Gryniewicz (GerritHub) < gerrit(a)gerrithub.io&gt; wrote: