erodriguez@lazyk-ranch.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1259543?usp=email ) Change subject: monitoring: register uptime gauge before Prometheus exposer starts ...................................................................... monitoring: register uptime gauge before Prometheus exposer starts With Enable_Metrics, prometheus_exposer__start() accepts scrapes before nfsv4_init_params() registers ganesha_uptime_info. A scrape during export/FSAL bring-up then monitoring__gauge_set()'s a NULL handle and segfaults in Gauge::Set. Register the uptime gauge before starting the exposer, keep the later register_ganesha_info_metrics path idempotent, and skip Set until the metric pointer is non-NULL. Change-Id: I5c82a7b5a767ed34a9fed95c74f9336a520f9f21 Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com> --- M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_main.c M src/MainNFSD/nfs_metrics.c M src/include/nfs_metrics.h M src/monitoring/prometheus_exposer.cc 5 files changed, 32 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/43/1259543/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1259543?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I5c82a7b5a767ed34a9fed95c74f9336a520f9f21 Gerrit-Change-Number: 1259543 Gerrit-PatchSet: 1 Gerrit-Owner: erodriguez@lazyk-ranch.com