From Daniel Gryniewicz <dang@redhat.com>: Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/422687 Change subject: FSAL_VFS: fix return value in vfs_open2 ...................................................................... FSAL_VFS: fix return value in vfs_open2 If set/getattr fails when handling O_EXCL, vfs_open2 still returns successfully; then it causes NULL ptr dereference when called from FSAL_MDCACHE since it is expecting a valid sub_handle pointer. Fix vfs_open2 to use an return a fsal_status_t Discovered by Fatih Acar <fatih.acar@gandi.net> Change-Id: Ib956ad9e8eec247a19cb8d2ed72b55362e6d53f6 Signed-off-by: Daniel Gryniewicz <dang@redhat.com> --- M src/FSAL/FSAL_VFS/file.c 1 file changed, 8 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/87/422687/1 -- To view, visit https://review.gerrithub.io/422687 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-MessageType: newchange Gerrit-Change-Id: Ib956ad9e8eec247a19cb8d2ed72b55362e6d53f6 Gerrit-Change-Number: 422687 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Gryniewicz <dang@redhat.com>