11:11 a.m.
kaleb(a)redhat.com has uploaded this change for review. (
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/451937
Change subject: build: use a version script for libganesha_nfsd.so
......................................................................
build: use a version script for libganesha_nfsd.so
Only expose symbols needed by applications, e.g. ganesha.nfsd and
the FSALs.
Add link flag the FSALs and the applications to not allow undefined
symbols as an aid to developers. If a new API is added and it is used
in an app or FSAL they will discover it immediately if they forget to
add it to the version script.
Tested (superficially) with FSAL_VFS and FSAL_GLUSTER.
Note that Fedora tried, circa f28 or so, to require "-z defs" (a.k.a.
--no-undefined). It will probably come back at some point, so we
will be ahead of the curve here.
Signed-off-by: Kaleb S. KEITHLEY <kkeithle(a)redhat.com>
Change-Id: I970d4735c9842a9a1c86081299297f7c471260a9
---
M src/CMakeLists.txt
M src/FSAL/FSAL_CEPH/CMakeLists.txt
M src/FSAL/FSAL_GLUSTER/CMakeLists.txt
M src/FSAL/FSAL_GPFS/CMakeLists.txt
M src/FSAL/FSAL_MEM/CMakeLists.txt
M src/FSAL/FSAL_PROXY/CMakeLists.txt
M src/FSAL/FSAL_RGW/CMakeLists.txt
M src/FSAL/FSAL_VFS/panfs/CMakeLists.txt
M src/FSAL/FSAL_VFS/vfs/CMakeLists.txt
M src/FSAL/FSAL_VFS/xfs/CMakeLists.txt
M src/FSAL/Stackable_FSALs/FSAL_NULL/CMakeLists.txt
M src/MainNFSD/CMakeLists.txt
A src/MainNFSD/libganesha_nfsd.ver
13 files changed, 233 insertions(+), 29 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/37/451937/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/451937
To unsubscribe, or for help writing mail filters, visit
https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I970d4735c9842a9a1c86081299297f7c471260a9
Gerrit-Change-Number: 451937
Gerrit-PatchSet: 1
Gerrit-Owner: kaleb(a)redhat.com
Gerrit-MessageType: newchange