David Rieber has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198233?usp=email ) Change subject: Do not unlock obj_lock twice, that leads to undefined behavior. ...................................................................... Do not unlock obj_lock twice, that leads to undefined behavior. If check_share_conflict ever returns ERR_FSAL_SHARE_DENIED obj_lock ends up getting unlocked twice: first inside check_share_conflict_and_update_locked, and then again inside fsal_start_global_io right after check_share_conflict_and_update_locked returns. Change-Id: Iac0413514232edaf9fb86aa12a1623186eb51e72 Signed-off-by: David Rieber <drieber@google.com> --- M src/FSAL/commonlib.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/1198233/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1198233?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iac0413514232edaf9fb86aa12a1623186eb51e72 Gerrit-Change-Number: 1198233 Gerrit-PatchSet: 1 Gerrit-Owner: David Rieber <drieber@google.com>