SOLVED! was RE: PLEASE READ - NO MERGE THIS WEEK - NEED TO PULL BACK AND ANALYZE FAILURES
I solved which patch was the culprit and have just pushed V6-dev.16. Thanks for your patience and code contributions. Frank Filz From: Frank Filz [mailto:ffilzlnx@mindspring.com] Sent: Friday, July 5, 2024 5:34 PM To: devel@lists.nfs-ganesha.org Subject: [NFS-Ganesha-Devel] PLEASE READ - NO MERGE THIS WEEK - NEED TO PULL BACK AND ANALYZE FAILURES Sorry, I just spent several hours trying to get a successful merge. I keep getting Ganesha crashing during the pynfs 4.0 RPLY8 test case. I thought I had it narrowed down to a particular patch, so rebuilt V6-dev.16 without that patch, and started a full pynfs 4.0 test run which promptly caused Ganesha to crash while running RPLY8. Based on the test case I actually suspect the courteous server support is causing the crash (it's a test that would be impacted by courteous server - establishing a lock then not renewing least for 2 lease periods). We are going to have step back and deeply analyze code to determine the cause of these crashes. In the meantime, I am rescinding all +2 code reviews. I will leave +1 code reviews in place. Thanks Frank Filz
For easy reference, can you post a link to the issue and to the commit that fixes it? Thanks! On Mon, Jul 8, 2024 at 5:47 PM Frank Filz <ffilzlnx@mindspring.com> wrote:
I solved which patch was the culprit and have just pushed V6-dev.16.
Thanks for your patience and code contributions.
Frank Filz
*From:* Frank Filz [mailto:ffilzlnx@mindspring.com] *Sent:* Friday, July 5, 2024 5:34 PM *To:* devel@lists.nfs-ganesha.org *Subject:* [NFS-Ganesha-Devel] PLEASE READ - NO MERGE THIS WEEK - NEED TO PULL BACK AND ANALYZE FAILURES
Sorry, I just spent several hours trying to get a successful merge. I keep getting Ganesha crashing during the pynfs 4.0 RPLY8 test case. I thought I had it narrowed down to a particular patch, so rebuilt V6-dev.16 without that patch, and started a full pynfs 4.0 test run which promptly caused Ganesha to crash while running RPLY8.
Based on the test case I actually suspect the courteous server support is causing the crash (it’s a test that would be impacted by courteous server – establishing a lock then not renewing least for 2 lease periods).
We are going to have step back and deeply analyze code to determine the cause of these crashes.
In the meantime, I am rescinding all +2 code reviews. I will leave +1 code reviews in place.
Thanks
Frank Filz _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
The culprit is this patch: https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1194944?usp=search I don’t have a fix for it, I’ve pushed back to Yoni Couriel for a fix. Frank From: David Rieber via Devel [mailto:devel@lists.nfs-ganesha.org] Sent: Monday, July 8, 2024 7:24 PM To: Frank Filz <ffilzlnx@mindspring.com> Cc: devel@lists.nfs-ganesha.org Subject: [NFS-Ganesha-Devel] Re: SOLVED! was RE: PLEASE READ - NO MERGE THIS WEEK - NEED TO PULL BACK AND ANALYZE FAILURES For easy reference, can you post a link to the issue and to the commit that fixes it? Thanks! On Mon, Jul 8, 2024 at 5:47 PM Frank Filz <ffilzlnx@mindspring.com <mailto:ffilzlnx@mindspring.com> > wrote: I solved which patch was the culprit and have just pushed V6-dev.16. Thanks for your patience and code contributions. Frank Filz From: Frank Filz [mailto:ffilzlnx@mindspring.com <mailto:ffilzlnx@mindspring.com> ] Sent: Friday, July 5, 2024 5:34 PM To: devel@lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org> Subject: [NFS-Ganesha-Devel] PLEASE READ - NO MERGE THIS WEEK - NEED TO PULL BACK AND ANALYZE FAILURES Sorry, I just spent several hours trying to get a successful merge. I keep getting Ganesha crashing during the pynfs 4.0 RPLY8 test case. I thought I had it narrowed down to a particular patch, so rebuilt V6-dev.16 without that patch, and started a full pynfs 4.0 test run which promptly caused Ganesha to crash while running RPLY8. Based on the test case I actually suspect the courteous server support is causing the crash (it’s a test that would be impacted by courteous server – establishing a lock then not renewing least for 2 lease periods). We are going to have step back and deeply analyze code to determine the cause of these crashes. In the meantime, I am rescinding all +2 code reviews. I will leave +1 code reviews in place. Thanks Frank Filz _______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org> To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org <mailto:devel-leave@lists.nfs-ganesha.org>
Thanks Frank for finding the culprit. Can you please share the command line steps to run the tests? Ideally, we can run it ourselves before uploading a patch to gerrit On Tue, Jul 9, 2024 at 8:08 AM Frank Filz <ffilzlnx@mindspring.com> wrote:
The culprit is this patch:
https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1194944?usp=search
I don’t have a fix for it, I’ve pushed back to Yoni Couriel for a fix.
Frank
*From:* David Rieber via Devel [mailto:devel@lists.nfs-ganesha.org] *Sent:* Monday, July 8, 2024 7:24 PM *To:* Frank Filz <ffilzlnx@mindspring.com> *Cc:* devel@lists.nfs-ganesha.org *Subject:* [NFS-Ganesha-Devel] Re: SOLVED! was RE: PLEASE READ - NO MERGE THIS WEEK - NEED TO PULL BACK AND ANALYZE FAILURES
For easy reference, can you post a link to the issue and to the commit that fixes it?
Thanks!
On Mon, Jul 8, 2024 at 5:47 PM Frank Filz <ffilzlnx@mindspring.com> wrote:
I solved which patch was the culprit and have just pushed V6-dev.16.
Thanks for your patience and code contributions.
Frank Filz
*From:* Frank Filz [mailto:ffilzlnx@mindspring.com] *Sent:* Friday, July 5, 2024 5:34 PM *To:* devel@lists.nfs-ganesha.org *Subject:* [NFS-Ganesha-Devel] PLEASE READ - NO MERGE THIS WEEK - NEED TO PULL BACK AND ANALYZE FAILURES
Sorry, I just spent several hours trying to get a successful merge. I keep getting Ganesha crashing during the pynfs 4.0 RPLY8 test case. I thought I had it narrowed down to a particular patch, so rebuilt V6-dev.16 without that patch, and started a full pynfs 4.0 test run which promptly caused Ganesha to crash while running RPLY8.
Based on the test case I actually suspect the courteous server support is causing the crash (it’s a test that would be impacted by courteous server – establishing a lock then not renewing least for 2 lease periods).
We are going to have step back and deeply analyze code to determine the cause of these crashes.
In the meantime, I am rescinding all +2 code reviews. I will leave +1 code reviews in place.
Thanks
Frank Filz
_______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
_______________________________________________ Devel mailing list -- devel@lists.nfs-ganesha.org To unsubscribe send an email to devel-leave@lists.nfs-ganesha.org
participants (3)
-
David Rieber -
Frank Filz -
Yoni Couriel