[NFS-Ganesha-Support] Re: Proxy FSAL - NFS4 -> 3

Alright, looking through some git blame -w, I think this broke and then was restored in 2912fad98e. Jim had a diff in 2014 (823625c5da) to make the code compile, but crucially the buffer code no longer had a “max len” just a length. I think this broke the “clever” reuse of the input buffdesc as the argument to GetFH (which has been there since 2012 from 878f45493e). The input when mapped is a 16-byte thingy (sizeof nfs23_map_handle_t), and GetFH needs to expand the 16-byte mapped handle into an FH4. I assume the code when written had a FH4_SIZE as it’s max length, rather than the fh_desc buffer appearing to be trimmed to 16-bytes (that is, I think there was a length separate from max length at the time or something). IIRC, all the handle mapping code *actually* passes around a buffer that is large enough for the largest FH4 plus some padding. So the “resizing” done in handle_to_wire that needs to be undone in wire_to_host can actually happen in-place but the len field doesn’t know that. Ganesha experts, does that sound right, historically? On Mon, Jun 28, 2021 at 22:14 Frank Filz <ffilzlnx(a)mindspring.com&gt; wrote: