Change in ...nfs-ganesha[next]: Throttling uid2grp requests in uid2grp_allocate_by_uid
by Sukruth Sridharan (GerritHub)
Sukruth Sridharan has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505740 )
Change subject: Throttling uid2grp requests in uid2grp_allocate_by_uid
......................................................................
Throttling uid2grp requests in uid2grp_allocate_by_uid
Extending the option to throttle ui2dgrp requests in
uid2grp_allocate_by_name to uid2grp_allocate_by_uid.
Change-Id: I43c47c23427a4c7453b1d15e2e14f728ad185ce0
Signed-off-by: ssukruth <sukruthsridharan(a)gmail.com>
---
M src/support/uid2grp.c
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/505740/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505740
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I43c47c23427a4c7453b1d15e2e14f728ad185ce0
Gerrit-Change-Number: 505740
Gerrit-PatchSet: 1
Gerrit-Owner: Sukruth Sridharan <sukruthsridharan(a)gmail.com>
Gerrit-MessageType: newchange
4 years, 1 month
READDIRPLUS missing few entries in ganesha 2.5
by Yogendra
Hi all, A customer reported a issue with ganesha 2.5.Few file entries were not returned by ganesha server in readdirplus calls.Customer executed ls -ld command with wildcard from shell script.We have debugged the client tcpdump and there were 13 READDIRPLUS calls with cookie=0. Correct file entries were returned 12 times in READIRPLUS reply but few entries were missed in one particular READIRDIRPLUS reply.
Please let us know if any particular fixes that were done in 'readdir' area will be helpful here.
ThanksYogendra
4 years, 1 month
Running pynfs on macOS
by Matthew DeVore
Quick update on macOS progress.
I just uploaded 4 patches to Gerrit which (along with other build hacks, shared
previously [1]) allow macOS to run the pynfs 4.0 suite without crashing.
I thought I may be done with crash bugs, but I hit another one while editing an
FSAL_MEM-backed file in Vim, and the pynfs 4.1 suite has at least one crash
failure too (related to lock misuse, similar to the last 4 patches).
I will continue to send patches for non-macOS-specific correctness bugs.
The pynfs 4.0 suite still has failures [2]. I may not address these at all,
depending on the root cause, since I'm not really concerned with FSAL_MEM in
particular, since I plan to be writing my own FSAL backend.
[1] https://github.com/matvore/nfs-ganesha
[2]
WRT5a st_write.testMaximumData : FAILURE
READ did not correspond to WRITE with large dataset
--
SATT18 st_setattr.testMixed : FAILURE
Changing size from 0 to 10 and owner to b'65534' using
stateid=0 should return NFS4_OK, instead got
NFS4ERR_PERM
--
SEC7 st_secinfo.testRPCSEC_GSS : FAILURE
SECINFO returned mechanism list without RPCSEC_GSS
--
OPEN30 st_open.testReplay : FAILURE
non-replayed open should fail should return
NFS4ERR_SHARE_DENIED, instead got NFS4_OK
--
OPEN25 st_open.testDenyWrite1 : FAILURE
OPEN with access==write on a write-denied file should
return NFS4ERR_SHARE_DENIED, instead got NFS4_OK
--
OPEN21 st_open.testDenyRead1 : FAILURE
OPEN with access==read on a read-denied file should
return NFS4ERR_SHARE_DENIED, instead got NFS4_OK
--
WRT5a st_write.testMaximumData : FAILURE
READ did not correspond to WRITE with large dataset
--
SATT18 st_setattr.testMixed : FAILURE
Changing size from 0 to 10 and owner to b'65534' using
stateid=0 should return NFS4_OK, instead got
NFS4ERR_PERM
--
SEC7 st_secinfo.testRPCSEC_GSS : FAILURE
SECINFO returned mechanism list without RPCSEC_GSS
--
OPEN30 st_open.testReplay : FAILURE
non-replayed open should fail should return
NFS4ERR_SHARE_DENIED, instead got NFS4_OK
--
OPEN25 st_open.testDenyWrite1 : FAILURE
OPEN with access==write on a write-denied file should
return NFS4ERR_SHARE_DENIED, instead got NFS4_OK
--
OPEN21 st_open.testDenyRead1 : FAILURE
OPEN with access==read on a read-denied file should
return NFS4ERR_SHARE_DENIED, instead got NFS4_OK
4 years, 1 month
Change in ...nfs-ganesha[next]: mdcache: do not remove sentinel ref in cih module
by Matthew DeVore (GerritHub)
Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505607 )
Change subject: mdcache: do not remove sentinel ref in cih module
......................................................................
mdcache: do not remove sentinel ref in cih module
Currently, the sentinel reference of an mdcache entry can be removed in
_state_del_locked (see last line in that function) as well as in
cih_remove_checked.
After the last ref is removed, mdcache_lru_unref calls mdcache_lru_clean
which calls mdc_clean_entry which calls cih_remove_checked, which
attempts to 'put' the reference again, which finally leads to the -1 ref
count.
Other calls to cih_remove checked have been amended with a put ref,
except one; mdc_up_try_release also tries to remove the sentinel ref
twice: once through cih_remove_latched and again explicitly right before
returning. This can also cause the refcnt to become negative, so its
use of cih_remove_latched need not be amended with another put ref.
Change-Id: I34caf72092b4c743b7b94450a24cbefcb442f1f0
Signed-off-by: Matthew DeVore <matvore(a)google.com>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_hash.h
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
3 files changed, 15 insertions(+), 23 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/07/505607/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505607
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I34caf72092b4c743b7b94450a24cbefcb442f1f0
Gerrit-Change-Number: 505607
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew DeVore <matvore(a)google.com>
Gerrit-MessageType: newchange
4 years, 1 month
Announce Push of V4-dev.41
by Frank Filz
Branch next
Tag:V4-dev.41
Merge Highlights
* PseudoFS lookup fails with ERR_FSAL_DELAY during export update
* systemd: bad Wants: and Needs:
* nfs41_session: correct lock creation/destruction
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
a7c6c03 Frank S. Filz V4-dev.41
28e457b Matthew DeVore nfs41_session: correct lock creation/destruction
367172b Kaleb S. KEITHLEY systemd: bad Wants: and Needs:
67f533f Frank S. Filz PseudoFS lookup fails with ERR_FSAL_DELAY during
export update
4 years, 1 month
Change in ...nfs-ganesha[next]: nfs41_session: correct lock creation/destruction
by Matthew DeVore (GerritHub)
Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505566 )
Change subject: nfs41_session: correct lock creation/destruction
......................................................................
nfs41_session: correct lock creation/destruction
There are some missing mutex/lock creation and destruction calls. Add
the missing ones.
pthreads on macOS does not tolerate usage of r/w locks and mutexes
without initialization. This fixes that for such platforms.
Change-Id: If492246b6bb11fbb7af0fc6ae430dcfe6c31185d
Signed-off-by: Matthew DeVore <matvore(a)google.com>
---
M src/Protocols/NFS/nfs4_op_create_session.c
M src/SAL/nfs41_session_id.c
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/505566/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/505566
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: If492246b6bb11fbb7af0fc6ae430dcfe6c31185d
Gerrit-Change-Number: 505566
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew DeVore <matvore(a)google.com>
Gerrit-MessageType: newchange
4 years, 1 month
Change in ...nfs-ganesha[next]: MDCACHE - Add MDCACHE {} config block
by Daniel Gryniewicz (GerritHub)
Daniel Gryniewicz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454929
Change subject: MDCACHE - Add MDCACHE {} config block
......................................................................
MDCACHE - Add MDCACHE {} config block
Add a config block name MDCACHE that is a copy of CACHEINODE. Both can
be configured, but MDCACHE will override CACHEINODE. This allows us to
deprecate CACHEINODE.
Change-Id: I49012723132ae6105b904a60d1a96bb2bf78d51b
Signed-off-by: Daniel Gryniewicz <dang(a)fprintf.net>
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c
M src/config_samples/ceph.conf
M src/config_samples/config.txt
M src/config_samples/ganesha.conf.example
M src/doc/man/ganesha-cache-config.rst
M src/doc/man/ganesha-config.rst
6 files changed, 31 insertions(+), 7 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/29/454929/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/454929
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I49012723132ae6105b904a60d1a96bb2bf78d51b
Gerrit-Change-Number: 454929
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz <dang(a)redhat.com>
Gerrit-MessageType: newchange
4 years, 1 month