July 2022 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

[S] Change in ...nfs-ganesha[next]: MDCACHE: Avoid refreshing valid mdcache attrs.
by Gaurav (GerritHub) 27 Jul '22

27 Jul '22

Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541703 ) Change subject: MDCACHE: Avoid refreshing valid mdcache attrs. ...................................................................... MDCACHE: Avoid refreshing valid mdcache attrs. No need to check for ATTR_RDATTR_ERR for request_mask in mdcache_test_attrs_trust, some callers could set it, which will result in refreshing mdcache attrs, since valid_mask won't match request_mask. Extra stat calls to refresh mdcache getattrs impacting NFSV3 low latency reads, since we could end up doing double getattrs in nfs3_complete_read. Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar(a)nutanix.com> Change-Id: I3e410c17e06f6c108ffb2e87bd4ccf96d298ac71 --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/541703/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541703 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3e410c17e06f6c108ffb2e87bd4ccf96d298ac71 Gerrit-Change-Number: 541703 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Fix check return value of encode_posix_acl
by liyinshu (GerritHub) 26 Jul '22

26 Jul '22

liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541610 ) Change subject: Fix check return value of encode_posix_acl ...................................................................... Fix check return value of encode_posix_acl Change-Id: Ic4ff488b6466d5c123667ab6c0ffc0867bcae02c Signed-off-by: liyinshu <liyinshu(a)bytedance.com> --- M src/Protocols/NFSACL/nfsacl_getacl.c 1 file changed, 12 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/541610/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541610 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic4ff488b6466d5c123667ab6c0ffc0867bcae02c Gerrit-Change-Number: 541610 Gerrit-PatchSet: 1 Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Fix for NLM_DENIED for lock requests (issue#834)
by Name of user not set (GerritHub) 20 Jul '22

20 Jul '22

yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541415 ) Change subject: Fix for NLM_DENIED for lock requests (issue#834) ...................................................................... Fix for NLM_DENIED for lock requests (issue#834) This is the fix for issue#834 NLM lock requests after GRACE period failed with NLM_DENIED Change-Id: I97bd733dc7961c0ed1a06af88ff6ee097479bd76 Signed-off-by: Yogendra Charya <Yogendra.Charya(a)ibm.com> --- M src/SAL/state_lock.c 1 file changed, 25 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/541415/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541415 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I97bd733dc7961c0ed1a06af88ff6ee097479bd76 Gerrit-Change-Number: 541415 Gerrit-PatchSet: 1 Gerrit-Owner: yogendra858(a)yahoo.com Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: MDCACHE: Use new altname for config block to correct use of either name
by Frank Filz (GerritHub) 19 Jul '22

19 Jul '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541398 ) Change subject: MDCACHE: Use new altname for config block to correct use of either name ...................................................................... MDCACHE: Use new altname for config block to correct use of either name The old mechanism was causing the mdcache parameters to be re-initialized after reading the cacheinode block. Now we correctly handle the block whichever name is used. Change-Id: Ifc750a49490a57001f074940e4c71f2a1b1a9229 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_read_conf.c 1 file changed, 15 insertions(+), 20 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/98/541398/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541398 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ifc750a49490a57001f074940e4c71f2a1b1a9229 Gerrit-Change-Number: 541398 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: CONFIG: Add alt name for block
by Frank Filz (GerritHub) 19 Jul '22

19 Jul '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541397 ) Change subject: CONFIG: Add alt name for block ...................................................................... CONFIG: Add alt name for block This allows a config block to have an alternate name to allow a period while a block is being renamed where both old and new are allowed. Change-Id: I73cc9861b4370aa3d7d60c6459c2ae4a7902f411 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/config_parsing/config_parsing.c M src/include/config_parsing.h 2 files changed, 22 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/541397/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541397 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I73cc9861b4370aa3d7d60c6459c2ae4a7902f411 Gerrit-Change-Number: 541397 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[XL] Change in ...nfs-ganesha[next]: Add Prometheus and Grafana monitoring stack to NFS Ganesha.
by Bjorn Leffler (GerritHub) 18 Jul '22

18 Jul '22

Bjorn Leffler has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541330 ) Change subject: Add Prometheus and Grafana monitoring stack to NFS Ganesha. ...................................................................... Add Prometheus and Grafana monitoring stack to NFS Ganesha. Measure, export, aggregate and display monitoring metrics for: 1. NFS requests, aggregated per {operation} and per {operation, export} - Request rates - Sent / received throughput rates in bytes/second. - Latency percentiles in ms as a histogram. - Request and Response sizing in bytes as a histogram. 2. Number of NFS worker threads in use. 3. Number of active NFS clients. 4. Metadata cache hit and miss rates, per {operation} and per {operation, export} 5. Rates of received and completed rpcs. 6. Number of RPCs in flight. 7. Per NFS client request and throughput rates. This change adds the first C++ file to NFS Ganesha. I tried to implement the monitoring in C only using the digitalocean C Prometheus client. This turned out to be a bottleneck that wasted 25% of all cpu and limited overall request throughput (https://github.com/digitalocean/prometheus-client-c/issues/59) This flatlined Ganesha requests/second performance. As there are no other C libraries, the monitoring code instead uses another C++ library, which doesn't have this performance problem. The C++ library is thread safe, so no locking is added in NFS Ganesha. By default, export metrics on TCP port 9587. Reuse the same port that is allocated to the nfs-ganesha exporter at https://github.com/prometheus/prometheus/wiki/Default-port-allocations Other changes: - Add a parameter to NFS core parameters to allow the user change the monitoring port. - As this change adds new library dependencies, guard it by the USE_MONITORING definition. - Add a new log component, COMPONENT_MONITORING - Add sample configuration file for Prometheus metrics aggregation. - Add sample configuration file for Grafana console. Signed-off-by: Bjorn Leffler <leffler(a)google.com> Change-Id: I825cf2283f6e9e8c450cbf2923f92137fbee7e58 --- M src/CMakeLists.txt M src/MainNFSD/CMakeLists.txt M src/MainNFSD/nfs_main.c M src/config_samples/config.txt A src/config_samples/grafana.dashboard.json A src/config_samples/prometheus.rules.yml M src/include/config-h.in.cmake M src/include/gsh_config.h M src/include/log.h A src/include/monitoring.h M src/log/log_functions.c A src/monitoring/CMakeLists.txt A src/monitoring/monitoring.cc A src/monitoring/monitoring_internal.h M src/support/fridgethr.c M src/support/nfs_read_conf.c M src/support/server_stats.c 17 files changed, 4,228 insertions(+), 12 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/30/541330/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541330 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I825cf2283f6e9e8c450cbf2923f92137fbee7e58 Gerrit-Change-Number: 541330 Gerrit-PatchSet: 1 Gerrit-Owner: Bjorn Leffler <leffler(a)google.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Fix increase once but decease twice on refcount
by liyinshu (GerritHub) 15 Jul '22

15 Jul '22

liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541266 ) Change subject: Fix increase once but decease twice on refcount ...................................................................... Fix increase once but decease twice on refcount Change-Id: I3941a74c081851d7ffcbafa9b381be9a5db8ca71 Signed-off-by: liyinshu <liyinshu(a)bytedance.com> --- A .vscode/settings.json M src/Protocols/NFS/nfs4_op_close.c M src/SAL/nfs4_state.c M src/include/sal_functions.h 4 files changed, 26 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/66/541266/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541266 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3941a74c081851d7ffcbafa9b381be9a5db8ca71 Gerrit-Change-Number: 541266 Gerrit-PatchSet: 1 Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com> Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: STATE: Remove extraneous put_ref for lock_list empty
by Frank Filz (GerritHub) 14 Jul '22

14 Jul '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541256 ) Change subject: STATE: Remove extraneous put_ref for lock_list empty ...................................................................... STATE: Remove extraneous put_ref for lock_list empty These put_ref were associated with the original handling of the pin ref in the old cache_inode. There is no matching get_ref so these cause unexpected release of the obj. Change-Id: I7bbf5f12b1046df8c12a1aa5eab480c5ddb63efd Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/state_lock.c M src/SAL/state_misc.c M src/include/sal_functions.h 3 files changed, 18 insertions(+), 39 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/56/541256/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541256 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7bbf5f12b1046df8c12a1aa5eab480c5ddb63efd Gerrit-Change-Number: 541256 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: STATE: remove extraneous put_ref from state_nlm_notify
by Frank Filz (GerritHub) 14 Jul '22

14 Jul '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541255 ) Change subject: STATE: remove extraneous put_ref from state_nlm_notify ...................................................................... STATE: remove extraneous put_ref from state_nlm_notify Change-Id: I470b09463b05f5fd3ecbc24580329f04359be58b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/SAL/state_lock.c 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/55/541255/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/541255 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I470b09463b05f5fd3ecbc24580329f04359be58b Gerrit-Change-Number: 541255 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0