[S] Change in ...nfs-ganesha[next]: Install fsalmem as a module
by Paulo Neves (GerritHub)
Paulo Neves has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542681 )
Change subject: Install fsalmem as a module
......................................................................
Install fsalmem as a module
This isn't a shared library, it's a module.
Change-Id: I2c1eb8414749b14603d7761f9a1060ec2ac3eb71
Signed-off-by: Paulo Neves <ptsneves(a)gmail.com>
Signed-off-by: Ross Burton <ross.burton(a)intel.com>
Signed-off-by: Ross Burton <ross(a)burtonini.com>
---
M src/FSAL/FSAL_MEM/CMakeLists.txt
1 file changed, 15 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/81/542681/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542681
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I2c1eb8414749b14603d7761f9a1060ec2ac3eb71
Gerrit-Change-Number: 542681
Gerrit-PatchSet: 1
Gerrit-Owner: Paulo Neves <ptsneves(a)gmail.com>
Gerrit-MessageType: newchange
7 months
[S] Change in ...nfs-ganesha[next]: Correct shebang for install_git_hooks
by Paulo Neves (GerritHub)
Paulo Neves has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542680 )
Change subject: Correct shebang for install_git_hooks
......................................................................
Correct shebang for install_git_hooks
OSTYPE and [[ are not defined for POSIX sh, only for
bash. Attempting to use a POSIX shell to run install_git_hooks.sh
would lead to errors. Checked with shellcheck that the script
is correct for bash.
Change-Id: I094cdbc1b0fc72c39190467993090dc31c1b2e28
Signed-off-by: Paulo Neves <ptsneves(a)gmail.com>
---
M src/scripts/git_hooks/install_git_hooks.sh
1 file changed, 16 insertions(+), 1 deletion(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/80/542680/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542680
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I094cdbc1b0fc72c39190467993090dc31c1b2e28
Gerrit-Change-Number: 542680
Gerrit-PatchSet: 1
Gerrit-Owner: Paulo Neves <ptsneves(a)gmail.com>
Gerrit-MessageType: newchange
7 months
[S] Change in ...nfs-ganesha[next]: Fix possible null pointer dereference
by Paulo Neves (GerritHub)
Paulo Neves has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542679 )
Change subject: Fix possible null pointer dereference
......................................................................
Fix possible null pointer dereference
If logging is enabled on nfs3_lookup, name is NULL initialized
and used. Assign name to a valid location before it is used.
Change-Id: I54276cfdd0c4eed879bccffb06f788f691e3b0af
Signed-off-by: Paulo Neves <ptsneves(a)gmail.com>
---
M src/Protocols/NFS/nfs3_lookup.c
1 file changed, 14 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/542679/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542679
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I54276cfdd0c4eed879bccffb06f788f691e3b0af
Gerrit-Change-Number: 542679
Gerrit-PatchSet: 1
Gerrit-Owner: Paulo Neves <ptsneves(a)gmail.com>
Gerrit-MessageType: newchange
7 months
[M] Change in ...nfs-ganesha[next]: Check whether request is a real replay to warn kernel's bug
by liyinshu (GerritHub)
liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542321 )
Change subject: Check whether request is a real replay to warn kernel's bug
......................................................................
Check whether request is a real replay to warn kernel's bug
If client use kernel 4.14.81 in https://kernel.org/, sometimes
different requests share the same slot and sequenceid, ganesha
thinks the latter request is a replay of former request, so
return the response of the former request as the reply of the
latter request. It can cause client hangs forever. For example,
OP_SEQUENCE comes first, and then comes OP_GETATTR which share
the same slot and sequenceid with the former OP_SEQUENCE, and
ganesha reply NFS4ERR_RETRY_UNCACHED_REP. Then nfs-client will
retry send the OP_GETATTR with the same slot and sequenceid,
and ganesha still reply NFS4ERR_RETRY_UNCACHED_REP, ..., this
will last forever. This bug, i.e. different requests share the
same slot and sequenceid, disappers in kernel 5.4.143, fixed by
some previous version.
Change-Id: I9108d3bbe5310c3eaf0c1d600668a18b9dabbf76
Signed-off-by: liyinshu <liyinshu(a)bytedance.com>
---
M src/Protocols/NFS/nfs4_Compound.c
M src/Protocols/NFS/nfs4_op_sequence.c
M src/include/nfs_proto_functions.h
M src/include/sal_data.h
4 files changed, 169 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/21/542321/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542321
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I9108d3bbe5310c3eaf0c1d600668a18b9dabbf76
Gerrit-Change-Number: 542321
Gerrit-PatchSet: 1
Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com>
Gerrit-MessageType: newchange
7 months, 1 week
[M] Change in ...nfs-ganesha[next]: Fix crash bcz slot->cached_result is null for replay request
by liyinshu (GerritHub)
liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542223 )
Change subject: Fix crash bcz slot->cached_result is null for replay request
......................................................................
Fix crash bcz slot->cached_result is null for replay request
Fix crash bcz slot->cached_result is null for replay request
Reproduce crash as follows:
thread1: receive a replay request, and found slot->cached_result not
null, assign slot to data->slot at nfs4_op_sequence.c:131,
and unlock the slot->lock.
thread2: receive a normal request, got slot->lock and
release_slot(slot), so slot->cached_result was set null.
thread1: in complete_op, assign *status with
data->slot->cached_result->status,
but data->slot->cached_result is null, so crash happens.
To fix crash, move the code which need slot->cached_result from
complete_op to nfs4_op_sequence, so thread1 can visit cached_result
with the guard of slot->lock. Besides, we need to save cached_result's
status in compound_data, so complete_op can get it.
Change-Id: Ib186774b85c9bb5c31bf5269d1f2adfd1b297f5d
Signed-off-by: liyinshu <liyinshu(a)bytedance.com>
---
M src/Protocols/NFS/nfs4_Compound.c
M src/Protocols/NFS/nfs4_op_sequence.c
M src/include/nfs_proto_data.h
3 files changed, 46 insertions(+), 11 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/542223/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542223
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Ib186774b85c9bb5c31bf5269d1f2adfd1b297f5d
Gerrit-Change-Number: 542223
Gerrit-PatchSet: 1
Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com>
Gerrit-MessageType: newchange
7 months, 2 weeks
[S] Change in ...nfs-ganesha[next]: Fix crash bcz slot->cached_result is null for replay request
by liyinshu (GerritHub)
liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542082 )
Change subject: Fix crash bcz slot->cached_result is null for replay request
......................................................................
Fix crash bcz slot->cached_result is null for replay request
Reproduce crash as follows:
thread1: receive a replay request, and found slot->cached_result not null,
assign slot to data->slot at nfs4_op_sequence.c:131, and unlock
the slot->lock.
thread2: receive a normal request, got slot->lock and release_slot(slot),
so slot->cached_result was set null.
thread1: in complete_op, assign *status with
data->slot->cached_result->status,
but data->slot->cached_result is null, so crash happens.
To fix crash, add pointer cached_result in compound_data, and save
slot->cached_result when found request replayed, in complete_op, get
cached_result from compound_data. Even though, other thread release slot
and set slot->cached_result with null, we can still get cacehd_result
from compound_data.
Change-Id: I92f472edc773bf357b35da1a1805e2d59c95a286
Signed-off-by: liyinshu <liyinshu(a)bytedance.com>
---
M src/Protocols/NFS/nfs4_Compound.c
M src/Protocols/NFS/nfs4_op_sequence.c
M src/include/nfs_proto_data.h
3 files changed, 41 insertions(+), 2 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/542082/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542082
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I92f472edc773bf357b35da1a1805e2d59c95a286
Gerrit-Change-Number: 542082
Gerrit-PatchSet: 1
Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com>
Gerrit-MessageType: newchange
7 months, 2 weeks
[M] Change in ...nfs-ganesha[next]: Fix crash at glist_del state_sharelist
by liyinshu (GerritHub)
liyinshu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542077 )
Change subject: Fix crash at glist_del state_sharelist
......................................................................
Fix crash at glist_del state_sharelist
If open_state's ref count is 1, reproduce crash as follows:
thread1: nfs4_op_close.c:180 inc open_state's ref to 2.
thread2: nfs4_op_lock:178 inc open_state's ref to 3.
thread1: nfs4_op_close.c:306 dec open_state's ref to 2.
thread1: nfs4_op_close.c:336 dec open_state's ref to 1.
thread2: nfs4_op_lock.c:598 add lock_state's state_sharelist to the tail of open_state's share_lockstates.
thread2: nfs4_op_lock.c:742 dec open_state's ref to 0 and free this open_state.
thread3: nfs4_op_free_stateid.c:120 state_del_locked(lock_state)
thread3: nfs4_state.c:458 glist_del(&lock_state->state_data.lock.state_sharelist)
thread3: gsh_list.h:102 left->next = right, crash happens, because left is open_state's share_lockstates,
and open_state has been freed by thread2, so it's a used after free.
The root cause is add lock_state's state_sharelist to the tail of open_state's share_lockstates, and the open_state
will be freed immediately. So before this, we check again whether state_open existed in hashtable.
Change-Id: Idc3a3171c52e6a86cc2c5c18e353702a34473e9e
Signed-off-by: liyinshu <liyinshu(a)bytedance.com>
---
A commit-msg
M src/Protocols/NFS/nfs4_op_lock.c
2 files changed, 113 insertions(+), 0 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/542077/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542077
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: Idc3a3171c52e6a86cc2c5c18e353702a34473e9e
Gerrit-Change-Number: 542077
Gerrit-PatchSet: 1
Gerrit-Owner: liyinshu <liyinshu(a)bytedance.com>
Gerrit-MessageType: newchange
7 months, 2 weeks
[S] Change in ...nfs-ganesha[next]: Init NFS3 lookup name before logging
by Name of user not set (GerritHub)
jwind(a)quobyte.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542039 )
Change subject: Init NFS3 lookup name before logging
......................................................................
Init NFS3 lookup name before logging
This is flagged by GCC 10 with -Wformat-overflow.
Change-Id: I6d36eb1895f76e5406fb166a96d41df6667f25e0
Signed-off-by: Jonas Windmüller <jwind(a)quobyte.com>
---
M src/Protocols/NFS/nfs3_lookup.c
1 file changed, 13 insertions(+), 3 deletions(-)
git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/39/542039/1
--
To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/542039
To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Change-Id: I6d36eb1895f76e5406fb166a96d41df6667f25e0
Gerrit-Change-Number: 542039
Gerrit-PatchSet: 1
Gerrit-Owner: jwind(a)quobyte.com
Gerrit-MessageType: newchange
7 months, 2 weeks
Announce Push of V4.0.8
by Frank Filz
Branch next
Tag:V4.0.8
Merge Highlights
* Fix for NLM_DENIED for lock requests (issue#834)
* Fix check return value of encode_posix_acl
* MDCACHE: Avoid refreshing valid mdcache attrs.
* CONFIG: Add alt name for block
* MDCACHE: Use new altname for config block to correct use of either name
Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com>
Contents:
98fc2a9bb Frank S. Filz V4.0.8
64c52da15 Frank S. Filz MULTILOCK: Make compile with latest ceph
4645b019f Yogendra Charya Fix for NLM_DENIED for lock requests (issue#834)
9629ad115 Gaurav Gangalwar MDCACHE: Avoid refreshing valid mdcache attrs.
ed3861472 liyinshu Fix check return value of encode_posix_acl
efb447b6a Frank S. Filz MDCACHE: Use new altname for config block to correct
use of either name
4fc7981c6 Frank S. Filz CONFIG: Add alt name for block
7 months, 3 weeks
