May 2022 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 19 Feb '24

19 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

[S] Change in ...nfs-ganesha[next]: MDCACHE - Fix race between unexport and LRU reap.
by Name of user not set (GerritHub) 31 May '22

31 May '22

pradeepthomas(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539078 ) Change subject: MDCACHE - Fix race between unexport and LRU reap. ...................................................................... MDCACHE - Fix race between unexport and LRU reap. MDCACHE entries can be pushed to the cleanup queue from unexport path (mdcache_unexport/mdcache_umount). In the meantime, the same entry can be reaped by lru_reap_impl (unexport path does not take QLOCK). If the entry is reaped Signed-off-by: Pradeep <pradeepthomas(a)gmail.com> Change-Id: I2b59aa881dd9d6a86f917b9fe20fdfd9873f98b7 --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c 1 file changed, 20 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/539078/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539078 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2b59aa881dd9d6a86f917b9fe20fdfd9873f98b7 Gerrit-Change-Number: 539078 Gerrit-PatchSet: 1 Gerrit-Owner: pradeepthomas(a)gmail.com Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Use after free issue reported by address_sanitizer Freed by: update_e...
by Gaurav (GerritHub) 31 May '22

31 May '22

Gaurav has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539075 ) Change subject: Use after free issue reported by address_sanitizer Freed by: update_export_commit->export_commit_common->copy_gsh_export->gsh_refstr_put Use after free by: init_op_context->set_op_context_export_fsal_no_release->gsh_refstr_get ...................................................................... Use after free issue reported by address_sanitizer Freed by: update_export_commit->export_commit_common->copy_gsh_export->gsh_refstr_put Use after free by: init_op_context->set_op_context_export_fsal_no_release->gsh_refstr_get Before reclaiming rcu pointer, Wait for RCU read-side critical sections to complete. Signed-off-by: Gaurav Gangalwar <gaurav.gangalwar(a)nutanix.com> Change-Id: I26cc389cc85c52196b3cdb878ad625877ca9d442 --- M src/support/refstr.c 1 file changed, 19 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/75/539075/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/539075 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I26cc389cc85c52196b3cdb878ad625877ca9d442 Gerrit-Change-Number: 539075 Gerrit-PatchSet: 1 Gerrit-Owner: Gaurav <gaurav.gangalwar(a)gmail.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: config: Avoid incorrect duplicate Export_id error
by Martin Schwenke (GerritHub) 23 May '22

23 May '22

Martin Schwenke has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/538588 ) Change subject: config: Avoid incorrect duplicate Export_id error ...................................................................... config: Avoid incorrect duplicate Export_id error At the moment the call to u.blk.check() looks up the default Export_id, not the one in the block being processed. Calling after do_block_load() means the desired Export_id, from the block being processed, will be checked. Fixes issue https://github.com/nfs-ganesha/nfs-ganesha/issues/818 Signed-off-by: Martin Schwenke <mschwenke(a)ddn.com> Change-Id: I9d4e1595d3b2bc6a0004a98b8c6b9638d78aa978 --- M src/config_parsing/config_parsing.c 1 file changed, 20 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/538588/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/538588 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I9d4e1595d3b2bc6a0004a98b8c6b9638d78aa978 Gerrit-Change-Number: 538588 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Schwenke <martin(a)meltin.net> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Use acl_free after calls to acl_get_qualifier
by Frank Filz (GerritHub) 23 May '22

23 May '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/538577 ) Change subject: Use acl_free after calls to acl_get_qualifier ...................................................................... Use acl_free after calls to acl_get_qualifier To simplify this, add inline functions to get uid or gid which then do the acl_free after extracting the value. Change-Id: Ia86f14dca7949587913c3902f6016b86dfdf1c39 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/posix_acls.c M src/Protocols/NFS/nfs_proto_tools.c M src/include/posix_acls.h 3 files changed, 38 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/538577/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/538577 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ia86f14dca7949587913c3902f6016b86dfdf1c39 Gerrit-Change-Number: 538577 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Silly patch to make some checkpatch errors.
by Frank Filz (GerritHub) 06 May '22

06 May '22

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537810 ) Change subject: Silly patch to make some checkpatch errors. ...................................................................... Silly patch to make some checkpatch errors. I can also mispel someting in the commit message message. Change-Id: I6d0e24f4edd5afe404e45d54b75eec5175f08c7a Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/MainNFSD/nfs_main.c 1 file changed, 15 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/537810/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537810 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I6d0e24f4edd5afe404e45d54b75eec5175f08c7a Gerrit-Change-Number: 537810 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

NFS Ganesha in mdcache_avl_qp_lookup_s()
by Krishna Harathi 06 May '22

06 May '22

Frank, Long time. We are seeing a crash shown below. After seeing the fix in this commit - https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/516675, I am posting a possible fix. (gdb) where #0 0x00000000004f2a34 in avl_dirent_hk_cmpf (lhs=0x2, rhs=0x7f82ebf8b5c8) at ../../../../FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.h:67 #1 0x00000000004f3d48 in avltree_do_lookup (tree=0x7f82d31bbd90, cmp_fn=0x4f2a30 <avl_dirent_hk_cmpf>, is_left=<synthetic pointer>, unbalanced=<synthetic pointer>, pparent=<synthetic pointer>, key=0x7f82ebf8b5c8) at ../../../../include/avltree.h:223 #2 avltree_inline_lookup (cmp_fn=0x4f2a30 <avl_dirent_hk_cmpf>, tree=0x7f82d31bbd90, key=0x7f82ebf8b5c8) at ../../../../include/avltree.h:244 #3 avltree_lookup (tree=0x7f82d31bbd90, key=0x7f82ebf8b5c8) at ../../../../include/avltree.h:252 #4 mdcache_avl_qp_lookup_s (entry=entry@entry=0x7f82d31bb800, name=name@entry=0x7f82c606f440 "meta.tmp", maxj=maxj@entry=1) at ../../../../FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_avl.c:779 Possible fix – diff mdcache_avl.c mdcache_avl.c.new 760a761,762 > memset(&v, 0, sizeof(v)); > I also suggest reviewing all callers of this avltree_lookup() for potential similar problems. Comments? Regards. Krishna Harathi _____________________________________________________________________________________________________________ [cid:arcserve-email-logo_566d469b-c8dc-46eb-909b-300e3f3e47a1.jpg]<https://arcserve.com/> Krishna Harathi | Senior Manager - Engineering Office: 503.475.5279 | Mobile: 503.475.5279 | krishna.harathi(a)arcserve.com arcserve.com<https://www.arcserve.com/> | Twitter<https://twitter.com/Arcserve> | LinkedIn<https://www.linkedin.com/company/arcserve/> | YouTube<https://www.youtube.com/user/arcserve> _____________________________________________________________________________________________________________ If you are not the intended recipient of this message or received it erroneously, please notify the sender and delete it, together with any attachments, and be advised that any dissemination or copying of this message is prohibited.

2 4

Re: Ganesha crash while doing Delegation recall
by Frank Filz 04 May '22

04 May '22

Delegations have not really been tested in quite some time. Frank From: Sunil Bhargo [mailto:sbhargo@vmware.com] Sent: Tuesday, May 3, 2022 4:19 PM To: Frank Filz <ffilzlnx(a)mindspring.com>; devel(a)lists.nfs-ganesha.org Cc: dang(a)redhat.com; Sriram Patil <sriramp(a)vmware.com> Subject: [NFS-Ganesha-Devel] Re: Ganesha crash while doing Delegation recall Frank, A question regarding the status of delegation on recent releases. Are the delegations supported or tested thoroughly in 4.0.5 or 3.5 Ganesha release. Thanks, Sunil Bhargo From: Frank Filz <ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> > Sent: Saturday, April 30, 2022 4:45 AM To: Sunil Bhargo <sbhargo(a)vmware.com <mailto:sbhargo@vmware.com> >; devel(a)lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org> Cc: dang(a)redhat.com <mailto:dang@redhat.com> ; Sriram Patil <sriramp(a)vmware.com <mailto:sriramp@vmware.com> > Subject: RE: [NFS-Ganesha-Devel] Ganesha crash while doing Delegation recall ⚠ External Email V2.8 is pretty old and no longer supported. Additionally, I don’t know if delegations have been tested or supported recently at all so I doubt there’s any fixes but you could certainly try a newer release, or look through the git history. Frank From: Sunil Bhargo [mailto:sbhargo@vmware.com] Sent: Thursday, April 28, 2022 6:21 AM To: devel(a)lists.nfs-ganesha.org <mailto:devel@lists.nfs-ganesha.org> Cc: ffilzlnx(a)mindspring.com <mailto:ffilzlnx@mindspring.com> ; dang(a)redhat.com <mailto:dang@redhat.com> ; Sriram Patil <sriramp(a)vmware.com <mailto:sriramp@vmware.com> > Subject: [NFS-Ganesha-Devel] Ganesha crash while doing Delegation recall Hi, Currently seeing the following crash and it is a recurrent crash. We are using ganesha 2.8.4. Can someone please help in telling if this is a known issue and whether it is fixed in later releases ? (gdb) bt #0 0x00007fcc26df6570 in pthread_mutex_lock () from /lib/libpthread.so.0 #1 0x00007fcc2760906c in svc_rqst_expire_insert () from /lib/libntirpc.so.1.8 #2 0x00007fcc275f2e19 in clnt_req_callback () from /lib/libntirpc.so.1.8 #3 0x00007fcc27855c3e in nfs_rpc_call () from /lib/libganesha_nfsd.so.2.8 #4 0x00007fcc27856a13 in nfs_rpc_cb_single () from /lib/libganesha_nfsd.so.2.8 #5 0x00007fcc278837a4 in delegrecall_one () from /lib/libganesha_nfsd.so.2.8 #6 0x00007fcc27884422 in delegrecall_impl () from /lib/libganesha_nfsd.so.2.8 #7 0x00007fcc27886900 in queue_delegrecall () from /lib/libganesha_nfsd.so.2.8 #8 0x00007fcc278e6da9 in fridgethr_start_routine () from /lib/libganesha_nfsd.so.2.8 #9 0x00007fcc26df3f87 in start_thread () from /lib/libpthread.so.0 #10 0x00007fcc268755bf in clone () from /lib/libc.so.6 This seems like a channel is removed while it is being accessed by the backchannel. Thanks, Sunil Bhargo _____ ⚠ External Email: This email originated from outside of the organization. Do not click links or open attachments unless you recognize the sender.

1 0

Change in ...nfs-ganesha[next]: EXPORT: Decrease the default Prefer Read/Write size
by vicente (GerritHub) 03 May '22

03 May '22

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537606 ) Change subject: EXPORT: Decrease the default Prefer Read/Write size ...................................................................... EXPORT: Decrease the default Prefer Read/Write size - For some older nfs client, e.g. libnfs 1.x, could not handle the read/write size more than 1M. Just decrease the default prefer read/write size to 1M for general nfs client. Change-Id: I957c0d90b2620aaf4728f8b62ee20fbbf303a059 Signed-off-by: Vicente Cheng <freeze.bilsted(a)gmail.com> --- M src/support/exports.c 1 file changed, 17 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/06/537606/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537606 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I957c0d90b2620aaf4728f8b62ee20fbbf303a059 Gerrit-Change-Number: 537606 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: scripts: make install_git_hook.sh is workable for macOS
by vicente (GerritHub) 03 May '22

03 May '22

vicente has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537604 ) Change subject: scripts: make install_git_hook.sh is workable for macOS ...................................................................... scripts: make install_git_hook.sh is workable for macOS Change-Id: Icc8ba0edd77ddb835d65f76dff5935314b109ea8 Signed-off-by: Vicente Cheng <freeze.bilsted(a)gmail.com> --- M src/scripts/git_hooks/install_git_hooks.sh 1 file changed, 19 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/04/537604/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/537604 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Icc8ba0edd77ddb835d65f76dff5935314b109ea8 Gerrit-Change-Number: 537604 Gerrit-PatchSet: 1 Gerrit-Owner: vicente <freeze.bilsted(a)gmail.com> Gerrit-MessageType: newchange

1 0