December 2020 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 19 Feb '24

19 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Monitoring in Ganesha?
by Bjorn Leffler 22 Nov '21

22 Nov '21

Apart from the counters that you can access through dbus, is there any other monitoring built into Ganesha? I'm thinking of adding it with this higher level plan: - Exporting metrics from Ganesha to Prometheus. - Aggregate data in Prometheus. - Display monitoring consoles and graphs with Grafana. - Package up Prometheus, Grafana and the preconfigured rules/dashboards as a Docker image. - This makes it straightforward to deploy monitoring alongside a Gansha binary. My rough coding plan for the code is to: - Add a USE_MONITORING directive to the CMakeLists.txt files. - Add a build dependency to the Prometheus C client <https://github.com/digitalocean/prometheus-client-c>. - Create a src/monitoring directory for the new source files and templates. - Increment counters and timers throughout the code. - Use histograms to compute latency percentiles, heatmaps, etc. Is this a good idea? Any objections or suggestions? Thanks, Bjorn

3 6

Issue with calling done_cb from a different thread for fsal_read2
by Chakra Divi 12 Jan '21

12 Jan '21

Hi all, I'm working to create an async model in fsal layer for my filesystem. As part of this, called "done_cb" for a read_req from my own thread in fsal layer. This causes hang and nfs4 stopped responding. Here is pseudo code for the read callback. i could see a similar implementation in FSAL_MEM (mem_handle.c) layer void fsal_read2_cb(void *cbArg, int err) { struct test_wa *wa = (struct test_wa*)cbArg; fsal_errors_t fsal_error = posix2fsal_error(err); struct root_op_context root_op_context; init_root_op_context(&root_op_context, wa->ctx_export, wa->fsal_export, 0, 0, UNKNOWN_REQUEST); wa->done_cb(wa->obj_hdl, fsalstat(fsal_error, err), wa->read_arg, wa->caller_arg); release_root_op_context(); free(wa); return; } Shouldn't we call done_cb from a custom thread ? Can you please let me know if i'm missing something and right way to do this - Thanks for the help Regards, Chakra

2 9

New stable release: 3.4
by Daniel Gryniewicz 22 Dec '20

22 Dec '20

The NFS-Ganesha project is happy to announce a new stable version of Ganesha and nTiRPC: Version 3.4. This is the latest version in our stable release branch. It contains over 80 bug fixes and improvements. Daniel

2 1

End of year holiday time and the project - no weekly call, no merges
by Frank Filz 18 Dec '20

18 Dec '20

Hi all, With the end of the year upon us, there will be no weekly conference calls or merges the last two weeks of the year. See you January 5th for the next weekly call and January 8th for the next weekly merge. Have a happy holiday season and rest of the year. Thanks Frank Filz

1 0

Test branch for v3.4
by Daniel Gryniewicz 18 Dec '20

18 Dec '20

Hi, all. I've pushed a test branch for the 3.4 release to https://github.com/nfs-ganesha/nfs-ganesha/tree/test It's passed preliminary testing, and is ready for review. If there are no objections, I'll push the final release on Tuesday. Daniel

1 0

Change in ...nfs-ganesha[next]: ProxyV3: Pass the *original* credentials to backends.
by Solomon Boulos (GerritHub) 17 Dec '20

17 Dec '20

Solomon Boulos has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/507879 ) Change subject: ProxyV3: Pass the *original* credentials to backends. ...................................................................... ProxyV3: Pass the *original* credentials to backends. With manage_gids set to true, op_ctx->creds gets replaced with a potentially large list (above the 16 limit). We actually just want to reflect what the client does (while Ganesha's MDCACHE will do the same manage_gids access test). Change-Id: I872b92f64fbec575b5da4185b94d623e507e3bb6 Signed-off-by: Solomon Boulos <boulos(a)google.com> --- M src/FSAL/FSAL_PROXY_V3/main.c 1 file changed, 26 insertions(+), 17 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/79/507879/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/507879 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I872b92f64fbec575b5da4185b94d623e507e3bb6 Gerrit-Change-Number: 507879 Gerrit-PatchSet: 1 Gerrit-Owner: Solomon Boulos <boulos(a)google.com> Gerrit-MessageType: newchange

1 0

Announce Push of V4-dev.46
by Frank Filz 17 Dec '20

17 Dec '20

Branch next Tag:V4-dev.46 Merge Highlights * CEPH: Fix problem with handle-key extension * config: restrict default protocols to nfs3/4 * Readdir - Don't back up dirent for whence-is-name * Fix GTest build Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 29e1aaa Frank S. Filz V4-dev.46 ef476fe Daniel Gryniewicz Fix GTest build 1ed5895 Daniel Gryniewicz Readdir - Don't back up dirent for whence-is-name 1b0e588 Dominique Martinet config: restrict default protocols to nfs3/4 af70208 Frank S. Filz CEPH: Introduce host_to_key and fix up use of host handles and handle-key 606b275 Frank S. Filz Allow host_to_key to return a key that is larger than the host handle da4b630 Frank S. Filz Clarify file handle transformation methods

1 0

Change in ...nfs-ganesha[next]: Allow host_to_key to return a key that is larger than the host handle
by Frank Filz (GerritHub) 16 Dec '20

16 Dec '20

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/507773 ) Change subject: Allow host_to_key to return a key that is larger than the host handle ...................................................................... Allow host_to_key to return a key that is larger than the host handle The host_to_key method may add AT MOST FSAL_KEY_EXTRA_BYTES. Callers of host_to_key MUST allocate this extra space. Change-Id: I70850dd7c14697549b8fc2c7545a07844ac67ac0 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c M src/include/fsal_api.h 2 files changed, 25 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/73/507773/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/507773 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I70850dd7c14697549b8fc2c7545a07844ac67ac0 Gerrit-Change-Number: 507773 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: CEPH: Introduce host_to_key and fix up use of host handles and handle...
by Frank Filz (GerritHub) 15 Dec '20

15 Dec '20

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/507717 ) Change subject: CEPH: Introduce host_to_key and fix up use of host handles and handle-key ...................................................................... CEPH: Introduce host_to_key and fix up use of host handles and handle-key After clarifying how the various handle forms are used, and noting that CEPH was missing host_to_key, it's clear that wire_to_host MUST produce a host handle (without the export_id), not a handle-key. If the handle-key (with the export_id) is needed, MDCACHE will call host_to_key. The create_handle method is passed a host handle NOT a handle-key so it must NOT expect the export_id to be there. Change-Id: I4e06731d4c27da5a89eda7c08b79f93de84a4855 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/export.c M src/FSAL/FSAL_CEPH/internal.h 2 files changed, 50 insertions(+), 16 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/507717/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/507717 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4e06731d4c27da5a89eda7c08b79f93de84a4855 Gerrit-Change-Number: 507717 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0