February 2024 - Devel - NFS Ganesha List Archives

[S] Change in ...nfs-ganesha[next]: Fix crash at release_lock_owner()-> _get_gsh_export_ref()
by Name of user not set (GerritHub) 12 Jun '24

12 Jun '24

skmprabhu252(a)gmail.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176303?usp=email ) Change subject: Fix crash at release_lock_owner()-> _get_gsh_export_ref() ...................................................................... Fix crash at release_lock_owner()-> _get_gsh_export_ref() Fix crash at release_lock_owner()-> _get_gsh_export_ref() And nfs4_op_free_stateid-> dec_state_t_ref() This issue has been introduced by the commits with the IDs 55545864 and 067058ad. please refer https://github.com/nfs-ganesha/nfs-ganesha/issues/1062 Change-Id: Idc1c539961e42a1a35f064a2bc227856a8e05b49 Signed-off-by: Prabhu Murugesan <prabhu.murugesan1(a)ibm.com> --- M src/SAL/nfs4_state.c 1 file changed, 35 insertions(+), 10 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/03/1176303/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176303?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idc1c539961e42a1a35f064a2bc227856a8e05b49 Gerrit-Change-Number: 1176303 Gerrit-PatchSet: 1 Gerrit-Owner: skmprabhu252(a)gmail.com

2 2

Announce Push of V6-dev.6
by Frank Filz 22 Feb '24

22 Feb '24

Branch next Tag:V6-dev.6 Merge Highlights * Enhance FSAL API to support atomic pre and post attributes * Two fixes to restricting open state per client * Enable libunwind in ganesha * bugfix: https://github.com/nfs-ganesha/nfs-ganesha/issues/1044 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 994a3ffe4 Frank S. Filz V6-dev.6 60865e664 sunpxyz bugfix: https://github.com/nfs-ganesha/nfs-ganesha/issues/1044 158f39582 Xueqian Hu Enable libunwind in ganesha 51ad56d7a Rojin George Update the config name to Max_Open_States_Per_Client a7734184f Rojin George Correct Open State/FD per NFS v4 Client d9c9e8499 Shahar Hochma FSAL_PROXY_V3: Implement atomic pre/post attrs 1973f0eee Shahar Hochma FSAL_MEM: Support pre/post attrs 79818b13e Shahar Hochma Change link, unlink and rename operations to return attomic pre/post attributes d27c1cbd4 Shahar Hochma Change creation operations to return pre/post attributes for parent

1 0

[S] Change in ...nfs-ganesha[next]: Update the config name to Max_Open_State_Per_Client
by Rojin George (GerritHub) 21 Feb '24

21 Feb '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177220?usp=email ) Change subject: Update the config name to Max_Open_State_Per_Client ...................................................................... Update the config name to Max_Open_State_Per_Client Change-Id: Ic1bfcd868ac84059c1a7c6e4a4de18580b3aeb17 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/SAL/nfs4_state.c M src/config_samples/config.txt M src/doc/man/ganesha-core-config.rst M src/include/gsh_config.h M src/support/nfs_read_conf.c 5 files changed, 8 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/20/1177220/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177220?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ic1bfcd868ac84059c1a7c6e4a4de18580b3aeb17 Gerrit-Change-Number: 1177220 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 20 Feb '24

20 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

[M] Change in ...nfs-ganesha[next]: DBus to summarise the FD usage
by Rojin George (GerritHub) 19 Feb '24

19 Feb '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177034?usp=email ) Change subject: DBus to summarise the FD usage ...................................................................... DBus to summarise the FD usage This CR adds in the DBus interface to summarize all FD related details, and dump the client details to log. Change-Id: Id13f4589e9aee20cc69956f5b76eb46a6e95e80e Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/FSAL/commonlib.c M src/SAL/nfs4_clientid.c M src/include/fsal.h M src/include/sal_functions.h M src/include/server_stats_private.h M src/support/export_mgr.c 6 files changed, 186 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/1177034/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177034?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id13f4589e9aee20cc69956f5b76eb46a6e95e80e Gerrit-Change-Number: 1177034 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Correct Open State/FD per NFS v4 Client
by Rojin George (GerritHub) 19 Feb '24

19 Feb '24

Rojin George has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177033?usp=email ) Change subject: Correct Open State/FD per NFS v4 Client ...................................................................... Correct Open State/FD per NFS v4 Client Current open_files_per_clients considers states like SHARE+LOCK+DELEG, but to restrict FD usage, we should consider only SHARE state. Change-Id: I36977b53c2b0c0eb93af3157651e4c20197492b4 Signed-off-by: Rojin George <itsmerojin(a)gmail.com> --- M src/SAL/nfs4_state.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/33/1177033/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1177033?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I36977b53c2b0c0eb93af3157651e4c20197492b4 Gerrit-Change-Number: 1177033 Gerrit-PatchSet: 1 Gerrit-Owner: Rojin George <itsmerojin(a)gmail.com>

1 0

Announce Push of V6-dev.5
by Frank Filz 16 Feb '24

16 Feb '24

Branch next Tag:V6-dev.5 Merge Highlights * ID Mapping, uid/gid management, and related creds changes * Handle delegation recalls for expired clients Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 9936f2cc8 Frank S. Filz V6-dev.5 b36f9572c Rojin George Handle delegation recalls for expired clients 4c5dde9bb Dipit Grover idmapper: Extract owner-domain set and clear as separate functions e7177f429 Dipit Grover idmapping: Extract user,group cache addition to separate functions 38dadd5d7 Dipit Grover uid2grp: Handle ERANGE return code when calling pw-functions 0505362d8 Dipit Grover nfs_creds: Apply minor refactoring to rpcsec_gss creds evaluation 8c5fb5de8 Dipit Grover nfs_creds: Fix rpcsec_gss handling for anonymous user 75ddeea03 Dipit Grover uid2grp: Extract add-user-groups-to-cache to a separate function 4aa7de962 Dipit Grover nfs_creds: Resolve extended groups from rpcsec_gss principal using nfsidmap d68dd112f Dipit Grover uid2grp: Expose principal2grp function for resolving extended groups using libnfsidmap c9b4d35e6 Dipit Grover uid2grp: Fix usage of uid2grp cache 386f34219 Dipit Grover uid2grp: Miscellaneous refactoring 71d319b21 Dipit Grover uid2grp_cache: Expose expiry related functions c659aad88 Dipit Grover idmapper: Add pwnam support for mapping principal to uid,gid c1b3c380c Dipit Grover idmapper: Refactor pwentname2id to accommodate large entries a1612d142 Dipit Grover idmapper_cache: Do not destroy the cache locks when clearing the caches c9ab01a13 Dipit Grover idmapper_cache: Do not re-insert expired entry's attributes

1 0

[S] Change in ...nfs-ganesha[next]: Use after free in fd_lru
by Name of user not set (GerritHub) 16 Feb '24

16 Feb '24

deepakarumugam.s(a)nutanix.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176997?usp=email ) Change subject: Use after free in fd_lru ...................................................................... Use after free in fd_lru Currently release function doesn't use close_fsal_fd instead it tries to replicate the functionality of close_fsal_fd with the exception that it doesn't remove the fd from fd lru.This is problematic because if the handle has a fd associated with it then the fd doesn't get released from the fd lru. There are code paths in mdcache - mdcache_new_entry for example that call release without calling close. This leads to use after free scenarios where the fd stays in the fd lru long after it is freed. We caught one such use after free scenario while running a workload with asan build This patch tries to resolve the issue by calling close_fsal_fd from within the release function Change-Id: I507347b4ca731d733033199f514759bc56d99fb3 Signed-off-by: Deepak Arumugam Sankara Subramanian <deepakarumugam.s(a)nutanix.com> --- M src/FSAL/FSAL_VFS/handle.c 1 file changed, 1 insertion(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/97/1176997/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176997?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507347b4ca731d733033199f514759bc56d99fb3 Gerrit-Change-Number: 1176997 Gerrit-PatchSet: 1 Gerrit-Owner: deepakarumugam.s(a)nutanix.com

1 0

[XS] Change in ...nfs-ganesha[next]: Fix memory leak in DRC
by Xueqian Hu (GerritHub) 16 Feb '24

16 Feb '24

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176959?usp=email ) Change subject: Fix memory leak in DRC ...................................................................... Fix memory leak in DRC When we allocate a new tpc drc in alloc_tcp_drc() we actually do allocate memory for drc->xt.t during rbtx_init call. But when we free a drc in free_tcp_drc() we are not actually freeing this pointer, which will cause a memory leak. Change-Id: Idfa4ab24686daefb11b8c1ffd92a711e624497e7 Signed-off-by: Xueqian Hu <xh140312(a)outlook.com> --- M src/RPCAL/nfs_dupreq.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/59/1176959/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176959?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idfa4ab24686daefb11b8c1ffd92a711e624497e7 Gerrit-Change-Number: 1176959 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

[XS] Change in ...nfs-ganesha[next]: Reduce the default value of Readdir_Res_Size to 16KB
by Name of user not set (GerritHub) 12 Feb '24

12 Feb '24

deepakarumugam.s(a)nutanix.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176782?usp=email ) Change subject: Reduce the default value of Readdir_Res_Size to 16KB ...................................................................... Reduce the default value of Readdir_Res_Size to 16KB userspace clients like libnfs set readdirplus.maxcount to 1MB in contrast to linux kernel clients. The kernel clients we have experimented with typically use 16KB. when a libnfs client tries to do a readdirplus on a huge directory - the corresponding thread seems to acquire directory->content_lock and doesn't release it for > 3 minutes - this means no other client ops can make progress during the time. The reason we are not releasing the lock is because we never hit tracker->mem_avail limit in nfs3_readdir_callback which is 1MB and we keep trying to fill more chunks In discussions in the github, we concluded that the best way to resolve this issue was bringing down Readdir_Res_Size. This commit brings down Readdir_Res_Size Reviewers : Tickets resolved : Tickets related : Tests run : Target release : Breaks rolling upgrade : Code review URL : Change-Id: I7e43a98ea9dece0be308fec69db84c75ba3fb0e8 Signed-off-by: Deepak Arumugam Sankara Subramanian <deepakarumugam.s(a)nutanix.com> --- M src/support/nfs_read_conf.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/1176782/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1176782?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7e43a98ea9dece0be308fec69db84c75ba3fb0e8 Gerrit-Change-Number: 1176782 Gerrit-PatchSet: 1 Gerrit-Owner: deepakarumugam.s(a)nutanix.com

1 0