June 2024 - Devel - NFS Ganesha List Archives

Announce Push of V6-dev.15
by Frank Filz 28 Jun '24

28 Jun '24

Branch next Tag:V6-dev.15 Merge Highlights * Build pseudo root with fileid 0 * open pidfile with O_TRUNC Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: 1c90b8769 Frank S. Filz V6-dev.15 01d5ca611 bjfhdhhaha open pidfile with O_TRUNC 63cb25281 Xueqian Hu Build pseudo root with fileid 0

1 0

[XS] Change in ...nfs-ganesha[next]: open pidfile with O_TRUNC
by bjfhdhhaha (GerritHub) 27 Jun '24

27 Jun '24

bjfhdhhaha has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196811?usp=email ) Change subject: open pidfile with O_TRUNC ...................................................................... open pidfile with O_TRUNC Change-Id: Id5f58c650e2b5a9ee5d9ce0b3855ac38951183b5 Signed-off-by: bjfhdhhaha <1453769042(a)qq.com> --- M src/MainNFSD/nfs_main.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/1196811/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196811?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id5f58c650e2b5a9ee5d9ce0b3855ac38951183b5 Gerrit-Change-Number: 1196811 Gerrit-PatchSet: 1 Gerrit-Owner: bjfhdhhaha <1453769042(a)qq.com>

1 0

[XS] Change in ...nfs-ganesha[next]: remove unused variables and functions
by bjfhdhhaha (GerritHub) 22 Jun '24

22 Jun '24

bjfhdhhaha has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196640?usp=email ) Change subject: remove unused variables and functions ...................................................................... remove unused variables and functions Change-Id: I7def8b88e4bc52eaab4a6559cc03d9119b38f14b Signed-off-by: bjfhdhhaha <1453769042(a)qq.com> --- M src/Protocols/NFS/nfs3_read.c M src/Protocols/NFS/nfs3_write.c 2 files changed, 0 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/40/1196640/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196640?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7def8b88e4bc52eaab4a6559cc03d9119b38f14b Gerrit-Change-Number: 1196640 Gerrit-PatchSet: 1 Gerrit-Owner: bjfhdhhaha <1453769042(a)qq.com>

1 0

[S] Change in ...nfs-ganesha[next]: Build pseudo root before creating other FSAL exports
by Xueqian Hu (GerritHub) 20 Jun '24

20 Jun '24

Xueqian Hu has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196572?usp=email ) Change subject: Build pseudo root before creating other FSAL exports ...................................................................... Build pseudo root before creating other FSAL exports Today, we will build pseudo root after parsing and creating all exports in ganesha conf file. In pseudofs_lookup_path, while allocating a new fsal_obj_handle, the fileid will start from 0, and get increased by 1 each time. For a normal case, pseudo root will be the only export in the PSEUDO FSAL, the fileid of pseudo root will always be 0. However, if adding other exports in PSEUDO FSAL, and restarting ganesha, those exports will get created first. That is mean, if we have NUM exports added, those exports fileids will be 0, 1, ..., (NUM - 1), and pseudo root's fileid will be changed to NUM. It will be good to keep fileid as 0 for pseudo root, otherwise, for a running client, it will hit error for inode number change: [2694122.907113] NFS: server 10.53.93.152 error: fileid changed In this patch, move the call to build pseudo root before building other FSAL exports which will make sure pseudo root's file id will always be 0. Change-Id: I45563c8d2ffa40858627dd0eb5d4145b046e142b Signed-off-by: Xueqian Hu <xh140312(a)outlook.com> --- M src/support/exports.c 1 file changed, 6 insertions(+), 6 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/72/1196572/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196572?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I45563c8d2ffa40858627dd0eb5d4145b046e142b Gerrit-Change-Number: 1196572 Gerrit-PatchSet: 1 Gerrit-Owner: Xueqian Hu <xh140312(a)outlook.com>

1 0

[L] Change in ...nfs-ganesha[next]: state_lock.c: Implement nfsv4 blocking locks support
by ofir vainshtein (GerritHub) 18 Jun '24

18 Jun '24

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196417?usp=email ) Change subject: state_lock.c: Implement nfsv4 blocking locks support ...................................................................... state_lock.c: Implement nfsv4 blocking locks support Change-Id: I05895d16465febfb7141a20ad52d0078a9a0a606 Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/Protocols/NFS/nfs4_op_lock.c M src/Protocols/NFS/nfs4_op_open.c M src/SAL/state_async.c M src/SAL/state_lock.c M src/include/sal_data.h M src/include/sal_functions.h 6 files changed, 655 insertions(+), 200 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/17/1196417/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196417?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I05895d16465febfb7141a20ad52d0078a9a0a606 Gerrit-Change-Number: 1196417 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[M] Change in ...nfs-ganesha[next]: nfs4_op_close: Release locks on close
by ofir vainshtein (GerritHub) 18 Jun '24

18 Jun '24

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196415?usp=email ) Change subject: nfs4_op_close: Release locks on close ...................................................................... nfs4_op_close: Release locks on close Change-Id: Idbd8eda4e9fd70e35275f7555616c452109d5369 Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/Protocols/NFS/nfs4_op_close.c M src/SAL/state_lock.c M src/include/sal_functions.h 3 files changed, 104 insertions(+), 47 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/15/1196415/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196415?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Idbd8eda4e9fd70e35275f7555616c452109d5369 Gerrit-Change-Number: 1196415 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[M] Change in ...nfs-ganesha[next]: sal_data.h: Factor out lock protocol type from blocking state
by ofir vainshtein (GerritHub) 18 Jun '24

18 Jun '24

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196416?usp=email ) Change subject: sal_data.h: Factor out lock protocol type from blocking state ...................................................................... sal_data.h: Factor out lock protocol type from blocking state Change-Id: I1d70ea7bac00e7169081102d8855ad60d1a6f5a2 Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/Protocols/9P/9p_lock.c M src/Protocols/NFS/nfs4_op_lock.c M src/Protocols/NLM/nlm_Lock.c M src/SAL/state_lock.c M src/include/sal_data.h M src/include/sal_functions.h 6 files changed, 66 insertions(+), 55 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/16/1196416/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196416?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1d70ea7bac00e7169081102d8855ad60d1a6f5a2 Gerrit-Change-Number: 1196416 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: nfs_rpc_callback: Assert in case no completion function is set as we ...
by ofir vainshtein (GerritHub) 18 Jun '24

18 Jun '24

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196414?usp=email ) Change subject: nfs_rpc_callback: Assert in case no completion function is set as we will have a cb resource leak ...................................................................... nfs_rpc_callback: Assert in case no completion function is set as we will have a cb resource leak Change-Id: I37dda138861243cf45cd8e0f69fbc0b950518acb Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/MainNFSD/nfs_rpc_callback.c 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/14/1196414/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196414?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I37dda138861243cf45cd8e0f69fbc0b950518acb Gerrit-Change-Number: 1196414 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[XS] Change in ...nfs-ganesha[next]: hashtable: Add more hashtable needed functions, to allow FSAL to crea...
by ofir vainshtein (GerritHub) 18 Jun '24

18 Jun '24

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196413?usp=email ) Change subject: hashtable: Add more hashtable needed functions, to allow FSAL to create hash table ...................................................................... hashtable: Add more hashtable needed functions, to allow FSAL to create hash table Change-Id: Ie4c79c7cc6e28ebbce795f7e9d2e2543a8648f1c Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/MainNFSD/libganesha_nfsd.ver 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/13/1196413/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196413?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Ie4c79c7cc6e28ebbce795f7e9d2e2543a8648f1c Gerrit-Change-Number: 1196413 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0

[S] Change in ...nfs-ganesha[next]: nfs_core: Make nfs_get_evchannel_id public
by ofir vainshtein (GerritHub) 18 Jun '24

18 Jun '24

ofir vainshtein has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196412?usp=email ) Change subject: nfs_core: Make nfs_get_evchannel_id public ...................................................................... nfs_core: Make nfs_get_evchannel_id public This will allow FSALs to use the same channels for their ntirpc servers Change-Id: I2ae137809fd7f0c64f5eb12ad128cbe5e5061e62 Signed-off-by: Ofir Vaisnhtein <ofirvins(a)google.com> --- M src/MainNFSD/libganesha_nfsd.ver M src/MainNFSD/nfs_rpc_dispatcher_thread.c M src/include/nfs_core.h 3 files changed, 21 insertions(+), 8 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/12/1196412/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/1196412?usp=email To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I2ae137809fd7f0c64f5eb12ad128cbe5e5061e62 Gerrit-Change-Number: 1196412 Gerrit-PatchSet: 1 Gerrit-Owner: ofir vainshtein <ofirvins(a)google.com>

1 0