October 2021 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 19 Feb '24

19 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Monitoring in Ganesha?
by Bjorn Leffler 22 Nov '21

22 Nov '21

Apart from the counters that you can access through dbus, is there any other monitoring built into Ganesha? I'm thinking of adding it with this higher level plan: - Exporting metrics from Ganesha to Prometheus. - Aggregate data in Prometheus. - Display monitoring consoles and graphs with Grafana. - Package up Prometheus, Grafana and the preconfigured rules/dashboards as a Docker image. - This makes it straightforward to deploy monitoring alongside a Gansha binary. My rough coding plan for the code is to: - Add a USE_MONITORING directive to the CMakeLists.txt files. - Add a build dependency to the Prometheus C client <https://github.com/digitalocean/prometheus-client-c>. - Create a src/monitoring directory for the new source files and templates. - Increment counters and timers throughout the code. - Use histograms to compute latency percentiles, heatmaps, etc. Is this a good idea? Any objections or suggestions? Thanks, Bjorn

3 6

Announce Push of V4-rc2
by Frank Filz 29 Oct '21

29 Oct '21

Branch next Tag:V4-rc2 Ganesha V4.0 is in sight! Merge Highlights * NLM - fix issues with SM_NOTIFY handling * NLM - allow NLM to send messages to IPv4 only clients * NLM - additional and cleaned up debugging * PROXY_V4 - fix wrong type used for return value * KVSFS - cleanup supported bits * CEPH - fix stuck readdir * Always initialize rwlock when creating acl object * Do not read a fsal_filesystem if type is incomplete * Fix flood of "fsal_common_is_referral :FSAL :EVENT :Failed to get attrs for referral" messages. Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> Contents: ef07e96e2 Frank S. Filz V4-rc2 4f2bf3953 Nuzhat Fathima Shaik Fix flood of "fsal_common_is_referral :FSAL :EVENT :Failed to get attrs for referral" messages. 7e5502b09 Matthew DeVore Do not read a fsal_filesystem if type is incomplete b5b55dc39 Matthew DeVore Always initialize rwlock when creating acl object a5cc08308 fenghua Zhen Fix readdir stuck. When ceph-radosgw returns part of the dirs results, ganesha marks the last result as DIR_TERMINATE and rescan, caused an endless loop. 0eab09fa0 Frank S. Filz Cleanup some bits of what is supported in FSAL_KVSFS a5c0e66a9 Frank S. Filz PROXY_V4: proxyv4_rpc_read_reply returns an int, don't store in an enum c58c033cf Frank S. Filz NLM: for async response, if no IPv6 address is available convert IPv4 address 08c11eff7 Frank S. Filz Fix up SM_NOTIFY caller_name 5df7769e7 Frank S. Filz NLM: Use IPv4 address instead of encapsulated for caller_name dc03cb3dc Frank S. Filz Remove nlm_owner reference count held by nlm_state 38b5e8dd6 Frank S. Filz nsm client always has a caller_name, don't use ssc_client in hash aa5e540d4 Frank S. Filz Improve nsm_client debugging f7711bbc7 Frank S. Filz Fixup a wrong log component, nlm_util should be COMPONENT_NLM 8b38e8b96 Frank S. Filz Remove unused parameter from get_nsm_client eb283dee7 Frank S. Filz Move convert_ipv6_to_ipv4 to rpc_tools.c and add is_loopback

1 0

Change in ...nfs-ganesha[next]: Keep pidfile locked while running
by Olivier Garaud (GerritHub) 29 Oct '21

29 Oct '21

Olivier Garaud has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526441 ) Change subject: Keep pidfile locked while running ...................................................................... Keep pidfile locked while running Change-Id: I83b0e039764fb505d0def059d6e980468dbdcaa6 Signed-off-by: Olivier Garaud <olivier.garaud(a)scality.com> --- M src/MainNFSD/nfs_main.c 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/41/526441/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526441 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I83b0e039764fb505d0def059d6e980468dbdcaa6 Gerrit-Change-Number: 526441 Gerrit-PatchSet: 1 Gerrit-Owner: Olivier Garaud <olivier.garaud(a)scality.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: NLM: for async response, if no IPv6 address is available convert IPv4...
by Frank Filz (GerritHub) 28 Oct '21

28 Oct '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526411 ) Change subject: NLM: for async response, if no IPv6 address is available convert IPv4 address ...................................................................... NLM: for async response, if no IPv6 address is available convert IPv4 address nlm_send_async always uses an IPv6 socket for the callback. When looking up caller_name, if we don't find an IPV6 address, look for an IPv4 address (that may be all there is, especially if the address is in /etc/hosts) and convert that to IPv6. Change-Id: I3bc876a9ae6be50b009ac38ab978cf93aea9c2c9 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NLM/nlm_async.c 1 file changed, 101 insertions(+), 27 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/11/526411/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526411 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3bc876a9ae6be50b009ac38ab978cf93aea9c2c9 Gerrit-Change-Number: 526411 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Fixup a wrong log component, nlm_util should be COMPONENT_NLM
by Frank Filz (GerritHub) 28 Oct '21

28 Oct '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526410 ) Change subject: Fixup a wrong log component, nlm_util should be COMPONENT_NLM ...................................................................... Fixup a wrong log component, nlm_util should be COMPONENT_NLM Change-Id: I3b67cfa6f40c99de3ddaf3ff752282fc3eb41d21 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NLM/nlm_util.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/10/526410/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526410 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I3b67cfa6f40c99de3ddaf3ff752282fc3eb41d21 Gerrit-Change-Number: 526410 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Cleanup some bits of what is supported in FSAL_KVSFS
by Frank Filz (GerritHub) 27 Oct '21

27 Oct '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526328 ) Change subject: Cleanup some bits of what is supported in FSAL_KVSFS ...................................................................... Cleanup some bits of what is supported in FSAL_KVSFS Also remove lock_op2 since it doesn't do anything and lock support is not claimed. Change-Id: I7ad2f6d3741f6a2267c230a01f68488fcf8ebc3b Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_KVSFS/kvsfs_file.c M src/FSAL/FSAL_KVSFS/kvsfs_handle.c M src/FSAL/FSAL_KVSFS/kvsfs_main.c M src/FSAL/FSAL_KVSFS/kvsfs_methods.h 4 files changed, 3 insertions(+), 115 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/28/526328/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526328 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I7ad2f6d3741f6a2267c230a01f68488fcf8ebc3b Gerrit-Change-Number: 526328 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: PROXY_V4: proxyv4_rpc_read_reply returns an int, don't store in an enum
by Frank Filz (GerritHub) 27 Oct '21

27 Oct '21

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526323 ) Change subject: PROXY_V4: proxyv4_rpc_read_reply returns an int, don't store in an enum ...................................................................... PROXY_V4: proxyv4_rpc_read_reply returns an int, don't store in an enum Change-Id: Iaaf65d667dbc721cee11d497bb0ee8df0d2c5181 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PROXY_V4/handle.c 1 file changed, 3 insertions(+), 7 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/23/526323/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526323 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Iaaf65d667dbc721cee11d497bb0ee8df0d2c5181 Gerrit-Change-Number: 526323 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Do not read a fsal_filesystem if type is incomplete
by Matthew DeVore (GerritHub) 26 Oct '21

26 Oct '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526278 ) Change subject: Do not read a fsal_filesystem if type is incomplete ...................................................................... Do not read a fsal_filesystem if type is incomplete fsal_filesystem is not defined when configured without GSH_CAN_HOST_LOCAL_FS. Signed-off-by: Matthew DeVore <matvore(a)google.com> Change-Id: I59678bb20945d66fcbc75a5797f9b4ffcf8d6a71 --- M src/FSAL/default_methods.c 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/78/526278/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526278 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I59678bb20945d66fcbc75a5797f9b4ffcf8d6a71 Gerrit-Change-Number: 526278 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <me(a)matvore.com> Gerrit-MessageType: newchange

1 0

Change in ...nfs-ganesha[next]: Always initialize rwlock when creating acl object
by Matthew DeVore (GerritHub) 26 Oct '21

26 Oct '21

Matthew DeVore has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526277 ) Change subject: Always initialize rwlock when creating acl object ...................................................................... Always initialize rwlock when creating acl object In one call site for nfs4_acl_alloc, there was error handling for the return of pthread_rwlock_init. I removed this I'm using PTHREAD_RWLOCK_init which abort()s on error. The glibc and macOS implementations of pthread_rwlock_init always return 0. See [0] and [1]. Initializing rwlock objects is critical in macOS, where unlike Linux, operations on non-initialized rwlock objects result in error, and zero'd out memory (as returned by calloc) is not considered a valid initialization state. [0] https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_rwlock_init.c… [1] https://opensource.apple.com/source/libpthread/libpthread-454.120.2/src/pth… Signed-off-by: Matthew DeVore <matvore(a)google.com> Change-Id: I802d9bd696979a6801e5ab8a70a0021ed6918720 --- M src/support/nfs4_acls.c 1 file changed, 7 insertions(+), 14 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/77/526277/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/526277 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I802d9bd696979a6801e5ab8a70a0021ed6918720 Gerrit-Change-Number: 526277 Gerrit-PatchSet: 1 Gerrit-Owner: Matthew DeVore <me(a)matvore.com> Gerrit-MessageType: newchange

1 0