March 2023 - Devel - NFS Ganesha List Archives

Change in ...nfs-ganesha[next]: Allow EXPORT pseudo path to be changed during export update
by Frank Filz (GerritHub) 19 Feb '24

19 Feb '24

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 ) Change subject: Allow EXPORT pseudo path to be changed during export update ...................................................................... Allow EXPORT pseudo path to be changed during export update This also fully allows adding or removing NFSv4 support from an export since we can now handle the PseudoFS swizzing that occurs. Note that an explicit PseudoFS export may be removed or added, though you can not change it from export_id 0 because we currently don't allow changing the export_id. Note that this patch doesn't handle DBUS add or remove export though that is an option to improve. I may add them to this patch (it wouldn't be that hard) but I want to get this reviewed as is right now. There are implications to a client of changing the PseudoFS. I have tested moving an export in the PseudoFS with a client mounted. The client will be able to continue accessing the export, though it may see an ESTALE error if it navigates out of the export. The current working directory will go bad and the pwd comment will fail indicating a disconnected mount. I have also seen referencing .. from the root of the export wrapping around back to the root (I believe this is how disconnected mounts are set up). FSAL_PSEUDO lookups and create handles (PUTFH or any use of an NFSv3 handle where the inode isn't cached) which fail during an export update are instead turned into ERR_FSAL_DELAY which turns into NFS4ERR_DELAY or NFS3ERR_JUKEBOX to force the client to retry under the completed update. Change-Id: I507dc17a651936936de82303ff1291677ce136be Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_PSEUDO/handle.c M src/MainNFSD/libganesha_nfsd.ver M src/Protocols/NFS/nfs4_pseudo.c M src/include/export_mgr.h M src/include/nfs_proto_functions.h M src/support/export_mgr.c M src/support/exports.c 7 files changed, 560 insertions(+), 203 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/34/490334/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/490334 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I507dc17a651936936de82303ff1291677ce136be Gerrit-Change-Number: 490334 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

2 2

Help needed on FD
by Alok Sinha 31 Jan '24

31 Jan '24

FD created at below path does not have correct link in /proc/self/fd. With vfs_readlink_by_handle , I can get a relative path but cannot get the absolute path of the FD. I need a suggestion for one of the below to get around a production bug: - How to get the full path of the FD? - How to get the parent vfs_fsal_obj_handle? - Anyway to bypass this flow by changing any config file? #0 vfs_create_handle (exp_hdl=0x55801aca22c0, hdl_desc=0x7f93889b1600, handle=0x7f93889b13f8, attrs_out=0x7f93889b1430) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/FSAL_VFS/handle.c:2020 #1 0x00007f94a1f0e13b in mdcache_locate_host (fh_desc=0x7f93889b1600, export=0x55801aca1f20, entry=0x7f93889b1578, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:1109 #2 0x00007f94a1f02455 in mdcache_create_handle (exp_hdl=0x55801aca1f20, fh_desc=0x7f93889b1600, handle=0x7f93889b15d8, attrs_out=0x0) at /home/alok/pub/splfs-cache-2.8.3/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1613 #3 0x00007f94a1ec5ead in nfs4_mds_putfh (data=0x7f93201119e0) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:211 #4 0x00007f94a1ec60d3 in nfs4_op_putfh (op=0x7f93201186d0, data=0x7f93201119e0, resp=0x7f932010ab20) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_op_putfh.c:281 #5 0x00007f94a1ea96ae in process_one_op (data=0x7f93201119e0, status=0x7f93889b1b48) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:920 #6 0x00007f94a1eaa8c5 in nfs4_Compound (arg=0x7f9320138d78, req=0x7f93201385a0, res=0x7f9320106840) at /home/alok/pub/splfs-cache-2.8.3/src/Protocols/NFS/nfs4_Compound.c:1329 #7 0x00007f94a1de8567 in nfs_rpc_process_request (reqdata=0x7f93201385a0) ---Type <return> to continue, or q <return> to quit--- at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1484 #8 0x00007f94a1de8854 in nfs_rpc_valid_NFS (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/MainNFSD/nfs_worker_thread.c:1591 #9 0x00007f94a13b6faf in svc_vc_decode (req=0x7f93201385a0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:829 #10 0x00007f94a13b3225 in svc_request (xprt=0x7f9320000ce0, xdrs=0x7f9320066260) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:793 #11 0x00007f94a13b6ec0 in svc_vc_recv (xprt=0x7f9320000ce0) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_vc.c:802 #12 0x00007f94a13b31a5 in svc_rqst_xprt_task (wpe=0x7f9320000f00) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/svc_rqst.c:774 #13 0x00007f94a13bcab0 in work_pool_thread (arg=0x7f9218003340) at /home/alok/pub/splfs-cache-2.8.3/src/libntirpc/src/work_pool.c:184 #14 0x00007f94a1badea5 in start_thread () from /lib64/libpthread.so.0 #15 0x00007f94a16ce9fd in clone () from /lib64/libc.so.6 -- Alok Sinha www.spillbox.io https://youtu.be/U-YupjLQ9bU

2 2

[S] Change in ...nfs-ganesha[next]: FSAL - oops - missed some fsal_fd stuff
by Frank Filz (GerritHub) 30 Mar '23

30 Mar '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551982 ) Change subject: FSAL - oops - missed some fsal_fd stuff ...................................................................... FSAL - oops - missed some fsal_fd stuff Change-Id: I308c8126ed1431e5b6b01b2fad2bbe95321dc096 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_GLUSTER/export.c M src/FSAL/FSAL_KVSFS/kvsfs_export.c M src/FSAL/FSAL_LIZARDFS/export.c M src/FSAL/FSAL_MEM/mem_export.c 5 files changed, 31 insertions(+), 9 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/82/551982/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551982 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I308c8126ed1431e5b6b01b2fad2bbe95321dc096 Gerrit-Change-Number: 551982 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: Fix for fail to unmount fs after removing all exports
by Name of user not set (GerritHub) 29 Mar '23

29 Mar '23

yogendra858(a)yahoo.com has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551874 ) Change subject: Fix for fail to unmount fs after removing all exports ...................................................................... Fix for fail to unmount fs after removing all exports Change-Id: I447437fdcce659319223d90ed3fe1e278ab2645c Signed-off-by: Yogendra Charya <Yogendra.Charya(a)ibm.com> --- M src/FSAL/FSAL_GPFS/export.c M src/FSAL/localfs.c M src/include/FSAL/fsal_localfs.h 3 files changed, 26 insertions(+), 1 deletion(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/74/551874/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551874 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I447437fdcce659319223d90ed3fe1e278ab2645c Gerrit-Change-Number: 551874 Gerrit-PatchSet: 1 Gerrit-Owner: yogendra858(a)yahoo.com Gerrit-MessageType: newchange

1 0

[M] Change in ...nfs-ganesha[next]: Expire lease immediately when reserve_lease fails.
by Frank Filz (GerritHub) 27 Mar '23

27 Mar '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551789 ) Change subject: Expire lease immediately when reserve_lease fails. ...................................................................... Expire lease immediately when reserve_lease fails. If a client request bumps into a lease that should have expired, expire it immediately rather than letting the reaper thread clean it up. This is because the client will set up a new clientid (EXCHANGE_ID or SET_CLIENTID) which ends up having the effect of not actually expiring the state. Change-Id: I61bfc3fad849592b505af8047ca96af2d0b14085 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/Protocols/NFS/nfs4_op_bind_conn.c M src/Protocols/NFS/nfs4_op_lockt.c M src/Protocols/NFS/nfs4_op_open.c M src/Protocols/NFS/nfs4_op_release_lockowner.c M src/Protocols/NFS/nfs4_op_renew.c M src/Protocols/NFS/nfs4_op_sequence.c M src/SAL/nfs4_lease.c M src/SAL/nfs4_state_id.c M src/include/sal_functions.h 9 files changed, 120 insertions(+), 73 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/89/551789/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551789 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I61bfc3fad849592b505af8047ca96af2d0b14085 Gerrit-Change-Number: 551789 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[S] Change in ...nfs-ganesha[next]: FSAL: posix2fsal_status(EBUSY); is too noisy
by Frank Filz (GerritHub) 27 Mar '23

27 Mar '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551788 ) Change subject: FSAL: posix2fsal_status(EBUSY); is too noisy ...................................................................... FSAL: posix2fsal_status(EBUSY); is too noisy Use fsalstat(ERR_FSAL_DELAY, EBUSY); instead even though it is wordier. Change-Id: Id0df45cb206e604a8fb2e828265bc11cf834cd97 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/commonlib.c 1 file changed, 21 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/88/551788/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551788 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: Id0df45cb206e604a8fb2e828265bc11cf834cd97 Gerrit-Change-Number: 551788 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

Multiple core related to state owner refcount being negative in state reclaim ops.
by Sagar Singh 24 Mar '23

24 Mar '23

Are we not guarding all the places by mutex where we do ref/unref? (gdb) bt #0 0x00007f58a18dc4fb in raise () from /lib64/libpthread.so.0 #1 0x00007f58a31e8a36 in crash_handler (signo=6, info=0x7f588e3f8470, ctx=0x7f588e3f8340) at /usr/src/debug/nfs-ganesha-4.0.2/MainNFSD/nfs_init.c:261 #2 <signal handler called> #3 0x00007f58a1113387 in raise () from /lib64/libc.so.6 #4 0x00007f58a1114a78 in abort () from /lib64/libc.so.6 #5 0x00007f58a110c1a6 in __assert_fail_base () from /lib64/libc.so.6 #6 0x00007f58a110c252 in __assert_fail () from /lib64/libc.so.6 #7 0x00007f58a3234338 in dec_state_owner_ref (owner=0x7f57ed99bc00) at /usr/src/debug/nfs-ganesha-4.0.2/SAL/state_misc.c:933 #8 0x00007f58a3241065 in nfs_client_id_expire (clientid=0x7f57e3929c00, make_stale=false) at /usr/src/debug/nfs-ganesha-4.0.2/SAL/nfs4_clientid.c:1093 #9 0x00007f58a32a4441 in nfs4_op_create_session (op=0x7f57f30f5aa0, data=0x7f5840d16e80, resp=0x7f57f30f5960) at /usr/src/debug/nfs-ganesha-4.0.2/Protocols/NFS/nfs4_op_create_session.c:444 #10 0x00007f58a329dfc6 in process_one_op (data=0x7f5840d16e80, status=0x7f588e3fc87c) at /usr/src/debug/nfs-ganesha-4.0.2/Protocols/NFS/nfs4_Compound.c:924 #11 0x00007f58a329f04e in nfs4_Compound (arg=0x7f57f30e9680, req=0x7f57f30e8e00, res=0x7f588408ac00) at /usr/src/debug/nfs-ganesha-4.0.2/Protocols/NFS/nfs4_Compound.c:1339 #12 0x00007f58a31e3664 in nfs_rpc_process_request (reqdata=0x7f57f30e8e00, retry=false) at /usr/src/debug/nfs-ganesha-4.0.2/MainNFSD/nfs_worker_thread.c:2079 #13 0x00007f58a31e3cdd in nfs_rpc_valid_NFS (req=0x7f57f30e8e00) at /usr/src/debug/nfs-ganesha-4.0.2/MainNFSD/nfs_worker_thread.c:2317 #14 0x00007f58a35bdba1 in svc_vc_decode (req=0x7f57f30e8e00) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_vc.c:1125 #15 0x00007f58a35b8cd3 in svc_request (xprt=0x7f57eab7f600, xdrs=0x7f588d7cc340) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_rqst.c:1229 #16 0x00007f58a35bdaa6 in svc_vc_recv (xprt=0x7f57eab7f600) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_vc.c:1098 #17 0x00007f58a35b8c37 in svc_rqst_xprt_task_recv (wpe=0x7f57eab7f8f0) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_rqst.c:1209 #18 0x00007f58a35b98ba in svc_rqst_epoll_loop (wpe=0x7f589e2e5030) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_rqst.c:1608 #19 0x00007f58a35c6dc5 in work_pool_thread (arg=0x7f588ea001e0) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/work_pool.c:190 #20 0x00007f58a18d4ea5 in start_thread () from /lib64/libpthread.so.0 #21 0x00007f58a11dbb0d in clone () from /lib64/libc.so.6 #0 0x00007f58a18dc4fb in raise () from /lib64/libpthread.so.0 #1 0x00007f58a31e8a36 in crash_handler (signo=6, info=0x7f588e3f8470, ctx=0x7f588e3f8340) at /usr/src/debug/nfs-ganesha-4.0.2/MainNFSD/nfs_init.c:261 #2 <signal handler called> #3 0x00007f58a1113387 in raise () from /lib64/libc.so.6 #4 0x00007f58a1114a78 in abort () from /lib64/libc.so.6 #5 0x00007f58a110c1a6 in __assert_fail_base () from /lib64/libc.so.6 #6 0x00007f58a110c252 in __assert_fail () from /lib64/libc.so.6 #7 0x00007f58a3234338 in dec_state_owner_ref (owner=0x7f57ed99bc00) at /usr/src/debug/nfs-ganesha-4.0.2/SAL/state_misc.c:933 #8 0x00007f58a3241065 in nfs_client_id_expire (clientid=0x7f57e3929c00, make_stale=false) at /usr/src/debug/nfs-ganesha-4.0.2/SAL/nfs4_clientid.c:1093 #9 0x00007f58a32a4441 in nfs4_op_create_session (op=0x7f57f30f5aa0, data=0x7f5840d16e80, resp=0x7f57f30f5960) at /usr/src/debug/nfs-ganesha-4.0.2/Protocols/NFS/nfs4_op_create_session.c:444 #10 0x00007f58a329dfc6 in process_one_op (data=0x7f5840d16e80, status=0x7f588e3fc87c) at /usr/src/debug/nfs-ganesha-4.0.2/Protocols/NFS/nfs4_Compound.c:924 #11 0x00007f58a329f04e in nfs4_Compound (arg=0x7f57f30e9680, req=0x7f57f30e8e00, res=0x7f588408ac00) at /usr/src/debug/nfs-ganesha-4.0.2/Protocols/NFS/nfs4_Compound.c:1339 #12 0x00007f58a31e3664 in nfs_rpc_process_request (reqdata=0x7f57f30e8e00, retry=false) at /usr/src/debug/nfs-ganesha-4.0.2/MainNFSD/nfs_worker_thread.c:2079 #13 0x00007f58a31e3cdd in nfs_rpc_valid_NFS (req=0x7f57f30e8e00) at /usr/src/debug/nfs-ganesha-4.0.2/MainNFSD/nfs_worker_thread.c:2317 #14 0x00007f58a35bdba1 in svc_vc_decode (req=0x7f57f30e8e00) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_vc.c:1125 #15 0x00007f58a35b8cd3 in svc_request (xprt=0x7f57eab7f600, xdrs=0x7f588d7cc340) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_rqst.c:1229 #16 0x00007f58a35bdaa6 in svc_vc_recv (xprt=0x7f57eab7f600) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_vc.c:1098 #17 0x00007f58a35b8c37 in svc_rqst_xprt_task_recv (wpe=0x7f57eab7f8f0) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_rqst.c:1209 #18 0x00007f58a35b98ba in svc_rqst_epoll_loop (wpe=0x7f589e2e5030) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/svc_rqst.c:1608 #19 0x00007f58a35c6dc5 in work_pool_thread (arg=0x7f588ea001e0) at /usr/src/debug/nfs-ganesha-4.0.2/libntirpc/src/work_pool.c:190 #20 0x00007f58a18d4ea5 in start_thread () from /lib64/libpthread.so.0 #21 0x00007f58a11dbb0d in clone () from /lib64/libc.so.6 (gdb) f 7 #7 0x00007f58a3234338 in dec_state_owner_ref (owner=0x7f57ed99bc00) at /usr/src/debug/nfs-ganesha-4.0.2/SAL/state_misc.c:933 933 assert(refcount > 0); (gdb) l 928 if (str_valid) 929 LogFullDebug(COMPONENT_STATE, 930 "Decrement refcount now=%" PRId32 " {%s}", 931 refcount, str); 932 933 assert(refcount > 0); 934 935 return; 936 } 937 (gdb) l - 918 hash_table_t *ht_owner; 919 920 if (isDebug(COMPONENT_STATE)) { 921 display_owner(&dspbuf, owner); 922 str_valid = true; 923 } 924 925 refcount = atomic_dec_int32_t(&owner->so_refcount); 926 927 if (refcount != 0) { (gdb) p owner->so_refcount $1 = -1

1 0

FW: Announcing the Spring 2023 NFS bake-a-thon
by Frank Filz 15 Mar '23

15 Mar '23

-----Original Message----- From: Steve Dickson [mailto:steved@redhat.com] Sent: Wednesday, March 15, 2023 11:46 AM To: nfsv4(a)ietf.org; linux-nfs(a)vger.kernel.org Subject: Announcing the Spring 2023 NFS bake-a-thon Hello, I am pleased to announce the Spring 2023 NFS bake-a-thon, April 24-28, 20223. You can find information on the nfsvbat.org website [1]. Like last spring, we will be running this event in virtual space. Please note the VPN registration and setup instructions so that you can punch into the BAT network. Look forward to seeing you (virtually) at the next BAT. steved. [1] http://nfsv4bat.org/Events/2023/Apr/BAT/index.html

1 0

[S] Change in ...nfs-ganesha[next]: DUPREQ: When dupreq completely drops a request, don't clean up response
by Frank Filz (GerritHub) 15 Mar '23

15 Mar '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551091 ) Change subject: DUPREQ: When dupreq completely drops a request, don't clean up response ...................................................................... DUPREQ: When dupreq completely drops a request, don't clean up response We never allocated a response, so no need to clean it up. Change-Id: I4dd607e4ff8779b60c4b3758a18d0ac5683939de Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/RPCAL/nfs_dupreq.c 1 file changed, 21 insertions(+), 4 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/91/551091/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551091 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I4dd607e4ff8779b60c4b3758a18d0ac5683939de Gerrit-Change-Number: 551091 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0

[L] Change in ...nfs-ganesha[next]: free_state may not always be able to be called with a valid export
by Frank Filz (GerritHub) 14 Mar '23

14 Mar '23

Frank Filz has uploaded this change for review. ( https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551045 ) Change subject: free_state may not always be able to be called with a valid export ...................................................................... free_state may not always be able to be called with a valid export Instead of trying to use the export attached to a state to call the FSAL free_state, use a function pointer which if non-NULL is used, otherwise we just gsh_free the state (which works for all in-tree FSALs). Change-Id: I1aa7cccc144a50c020ee0f5d450b110686ac6647 Signed-off-by: Frank S. Filz <ffilzlnx(a)mindspring.com> --- M src/FSAL/FSAL_CEPH/export.c M src/FSAL/FSAL_CEPH/handle.c M src/FSAL/FSAL_CEPH/internal.h M src/FSAL/FSAL_GLUSTER/export.c M src/FSAL/FSAL_GLUSTER/gluster_internal.h M src/FSAL/FSAL_GPFS/export.c M src/FSAL/FSAL_GPFS/fsal_internal.h M src/FSAL/FSAL_KVSFS/kvsfs_export.c M src/FSAL/FSAL_KVSFS/kvsfs_methods.h M src/FSAL/FSAL_LIZARDFS/export.c M src/FSAL/FSAL_LIZARDFS/lzfs_internal.h M src/FSAL/FSAL_MEM/mem_export.c M src/FSAL/FSAL_MEM/mem_int.h M src/FSAL/FSAL_PROXY_V4/export.c M src/FSAL/FSAL_PROXY_V4/handle.c M src/FSAL/FSAL_PROXY_V4/proxyv4_fsal_methods.h M src/FSAL/FSAL_RGW/handle.c M src/FSAL/FSAL_VFS/export.c M src/FSAL/FSAL_VFS/file.c M src/FSAL/FSAL_VFS/vfs_methods.h M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_export.c M src/FSAL/Stackable_FSALs/FSAL_NULL/export.c M src/FSAL/default_methods.c M src/Protocols/9P/9p_proto_tools.c M src/Protocols/NFS/nfs4_op_open.c M src/SAL/nfs4_state.c M src/SAL/nfs4_state_id.c M src/SAL/nlm_state.c M src/gtest/fsal_api/test_close2_latency.cc M src/gtest/fsal_api/test_commit2_latency.cc M src/gtest/fsal_api/test_open2_latency.cc M src/gtest/fsal_api/test_read2_latency.cc M src/gtest/fsal_api/test_reopen2_latency.cc M src/gtest/fsal_api/test_write2_latency.cc M src/include/FSAL/fsal_commonlib.h M src/include/fsal_api.h M src/include/sal_data.h 37 files changed, 63 insertions(+), 201 deletions(-) git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha refs/changes/45/551045/1 -- To view, visit https://review.gerrithub.io/c/ffilz/nfs-ganesha/+/551045 To unsubscribe, or for help writing mail filters, visit https://review.gerrithub.io/settings Gerrit-Project: ffilz/nfs-ganesha Gerrit-Branch: next Gerrit-Change-Id: I1aa7cccc144a50c020ee0f5d450b110686ac6647 Gerrit-Change-Number: 551045 Gerrit-PatchSet: 1 Gerrit-Owner: Frank Filz <ffilzlnx(a)mindspring.com> Gerrit-MessageType: newchange

1 0